heartbeat recovery message - #34457

Merged
potiuk merged 1 commit into
apache:mainfrom
Bowrna:heartbeat-message-enhancement
Apr 5, 2024
Merged

heartbeat recovery message #34457
potiuk merged 1 commit into
apache:mainfrom
Bowrna:heartbeat-message-enhancement

Conversation

@Bowrna

@BowrnaBowrna commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

related: #31810
closed: #31810

this covers the point C of the issue

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added the area:Scheduler including HA (high availability) scheduler label Sep 18, 2023
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch 4 times, most recently from df94736 to 55faf46CompareSeptember 19, 2023 07:31
Lee-W
Lee-W reviewed Sep 19, 2023
View reviewed changes
Comment threadairflow/jobs/job.py Outdated
Comment threadairflow/jobs/job.py Outdated
Comment threadairflow/jobs/job.py Outdated
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch from 5c097d4 to a33cf10CompareSeptember 21, 2023 17:09
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch from a33cf10 to 1730227CompareOctober 1, 2023 04:45
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch from d051cb4 to 9d82803CompareOctober 13, 2023 12:35
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch 8 times, most recently from c21c011 to 54e6c96CompareNovember 1, 2023 07:10
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch from 54e6c96 to f77fa86CompareNovember 1, 2023 09:11
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch 5 times, most recently from 0328759 to 139f4aaCompareNovember 2, 2023 04:34
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch 2 times, most recently from 984c74c to dfaaabeCompareDecember 3, 2023 15:27
@potiuk

potiuk commented Mar 9, 2024

Copy link
Copy Markdown
Member

this looks good @Bowrna (except the static check failing) - but I have one small proposal. It took me a bit of time to see why grace_multiplier is not passed to to the method in heartbeat - and I found out that even if it is specified in is_alive method, it's never set to anything diffferent than 2.1. And I think it's placed wrrongly. it should not be parameter of is_alive, but it should be - similarly as heartrate for example) added as Job's field in Job's constructor.

self.grace_multiplier = 2.1

And then - it should be taken from job whenever needed (similarly as we take job.job_type).

It would be great to change it here - because we are anyhow touching the same code, but If you think it's too much, I am fine to approve it even without it (and you could do it as a follow-up for example).

@Bowrna

Bowrna commented Mar 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@potiuk i will add the changes that you have suggested

@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch 2 times, most recently from 3176485 to f28a5b7CompareMarch 20, 2024 06:27
@Bowrna

Bowrna commented Mar 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?

potiuk
potiuk approved these changes Mar 20, 2024
View reviewed changes

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would love some other committer to take a look - it's quite crucial part of our processing and we had some issues that have been overlooked there in the past - for example #37992

@potiuk

potiuk commented Mar 20, 2024

Copy link
Copy Markdown
Member

@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?

Yes. Grace_multiplier is not set anywhere to a different value than default 2.1 now.

@potiuk

potiuk commented Mar 20, 2024

Copy link
Copy Markdown
Member

(or so I saw from reviewing the code myself). It's still good to keep it though in case we have a case we want to override it.

@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch from f28a5b7 to eef776fCompareMarch 20, 2024 09:19
@BowrnaBowrna closed this Mar 20, 2024
@BowrnaBowrna reopened this Mar 20, 2024
@potiuk

potiuk commented Mar 20, 2024

Copy link
Copy Markdown
Member

Looks like real issues.

@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch 3 times, most recently from 2e4b788 to fd2e4e1CompareMarch 20, 2024 14:54
@Bowrna

Bowrna commented Mar 21, 2024

Copy link
Copy Markdown
ContributorAuthor

Test is failing in the health api call testcases. let me debug the issue and fix it by EOD

@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch from fd2e4e1 to ddc7d44CompareMarch 21, 2024 08:43
Bowrna
Bowrna commented Mar 21, 2024
View reviewed changes
Comment threadairflow/jobs/job.py Outdated
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch 2 times, most recently from d0b3f94 to 40c4b33CompareApril 4, 2024 06:26
@Bowrna
Bowrnaforce-pushed the heartbeat-message-enhancement branch from 40c4b33 to dda9b36CompareApril 4, 2024 06:43
@Bowrna

Bowrna commented Apr 4, 2024

Copy link
Copy Markdown
ContributorAuthor

All green now :)

@potiuk
potiuk merged commit 6c866f4 into apache:mainApr 5, 2024
@potiuk

potiuk commented Apr 5, 2024

Copy link
Copy Markdown
Member

🎉

@ephraimbuddyephraimbuddy added the type:improvement Changelog: Improvements label Jun 3, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@potiukpotiukpotiuk approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees

No one assigned

Labels

area:Schedulerincluding HA (high availability) schedulertype:improvementChangelog: Improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve log messages of heartbeat connection errors and recovery

5 participants

@Bowrna@potiuk@Lee-W@amoghrajesh@ephraimbuddy
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
heartbeat recovery message  - #34457
Merged
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Apr 5, 2024
Merged
heartbeat recovery message #34457
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Conversation
@Bowrna
@BowrnaBowrna
commented
Sep 18, 2023

Copy link


Copy Markdown

Contributor
related: #31810
closed: #31810
this covers the point C of the issue
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:Scheduler
including HA (high availability) scheduler
label
Sep 18, 2023
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
4 times, most recently
from
df94736 to
55faf46CompareSeptember 19, 2023 07:31
Lee-W
Lee-W
reviewed
Sep 19, 2023
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
5c097d4 to
a33cf10CompareSeptember 21, 2023 17:09
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
a33cf10 to
1730227CompareOctober 1, 2023 04:45
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
d051cb4 to
9d82803CompareOctober 13, 2023 12:35
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
8 times, most recently
from
c21c011 to
54e6c96CompareNovember 1, 2023 07:10
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
54e6c96 to
f77fa86CompareNovember 1, 2023 09:11
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
5 times, most recently
from
0328759 to
139f4aaCompareNovember 2, 2023 04:34
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
984c74c to
dfaaabeCompareDecember 3, 2023 15:27
@potiuk
potiuk
commented
Mar 9, 2024

Copy link


Copy Markdown

Member
this looks good @Bowrna (except the static check failing) - but I have one small proposal. It took me a bit of time to see why grace_multiplier is not passed to to the method in heartbeat - and I found out that even if it is specified in is_alive method, it's never set to anything diffferent than 2.1. And I think it's placed wrrongly. it should not be parameter of is_alive, but it should be - similarly as heartrate for example) added as Job's field in Job's constructor.
self.grace_multiplier = 2.1

And then - it should be taken from job whenever needed (similarly as we take job.job_type).
It would be great to change it here - because we are anyhow touching the same code, but If you think it's too much, I am fine to approve it even without it (and you could do it as a follow-up for example).
@Bowrna
Bowrna
commented
Mar 13, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i will add the changes that you have suggested
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
3176485 to
f28a5b7CompareMarch 20, 2024 06:27
@Bowrna
Bowrna
commented
Mar 20, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
potiuk
potiuk
approved these changes
Mar 20, 2024
View reviewed changes
@potiukpotiuk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would love some other committer to take a look - it's quite crucial part of our processing and we had some issues that have been overlooked there in the past - for example #37992
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
Yes. Grace_multiplier is not set anywhere to a different value than default 2.1 now.
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
(or so I saw from reviewing the code myself). It's still good to keep it though in case we have a case we want to override it.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
f28a5b7 to
eef776fCompareMarch 20, 2024 09:19
@BowrnaBowrna
closed this
Mar 20, 2024
@BowrnaBowrna
reopened this
Mar 20, 2024
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
Looks like real issues.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
3 times, most recently
from
2e4b788 to
fd2e4e1CompareMarch 20, 2024 14:54
@Bowrna
Bowrna
commented
Mar 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Test is failing in the health api call testcases. let me debug the issue and fix it by EOD
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
fd2e4e1 to
ddc7d44CompareMarch 21, 2024 08:43
Bowrna
Bowrna
commented
Mar 21, 2024
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
d0b3f94 to
40c4b33CompareApril 4, 2024 06:26
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
40c4b33 to
dda9b36CompareApril 4, 2024 06:43
@Bowrna
Bowrna
commented
Apr 4, 2024

Copy link


Copy Markdown

ContributorAuthor
All green now :)
@potiuk
potiuk
merged commit 6c866f4
into
apache:mainApr 5, 2024
@potiuk
potiuk
commented
Apr 5, 2024

Copy link


Copy Markdown

Member
🎉
@ephraimbuddyephraimbuddy
added
the 
type:improvement
Changelog: Improvements
label
Jun 3, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@potiukpotiukpotiuk approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees


No one assigned


Labels

area:Schedulerincluding HA (high availability) schedulertype:improvementChangelog: Improvements

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Improve log messages of heartbeat connection errors and recovery


5 participants

@Bowrna@potiuk@Lee-W@amoghrajesh@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
heartbeat recovery message  - #34457
Merged
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Apr 5, 2024
Merged
heartbeat recovery message #34457
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Conversation
@Bowrna
@BowrnaBowrna
commented
Sep 18, 2023

Copy link


Copy Markdown

Contributor
related: #31810
closed: #31810
this covers the point C of the issue
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:Scheduler
including HA (high availability) scheduler
label
Sep 18, 2023
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
4 times, most recently
from
df94736 to
55faf46CompareSeptember 19, 2023 07:31
Lee-W
Lee-W
reviewed
Sep 19, 2023
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
5c097d4 to
a33cf10CompareSeptember 21, 2023 17:09
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
a33cf10 to
1730227CompareOctober 1, 2023 04:45
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
d051cb4 to
9d82803CompareOctober 13, 2023 12:35
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
8 times, most recently
from
c21c011 to
54e6c96CompareNovember 1, 2023 07:10
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
54e6c96 to
f77fa86CompareNovember 1, 2023 09:11
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
5 times, most recently
from
0328759 to
139f4aaCompareNovember 2, 2023 04:34
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
984c74c to
dfaaabeCompareDecember 3, 2023 15:27
@potiuk
potiuk
commented
Mar 9, 2024

Copy link


Copy Markdown

Member
this looks good @Bowrna (except the static check failing) - but I have one small proposal. It took me a bit of time to see why grace_multiplier is not passed to to the method in heartbeat - and I found out that even if it is specified in is_alive method, it's never set to anything diffferent than 2.1. And I think it's placed wrrongly. it should not be parameter of is_alive, but it should be - similarly as heartrate for example) added as Job's field in Job's constructor.
self.grace_multiplier = 2.1

And then - it should be taken from job whenever needed (similarly as we take job.job_type).
It would be great to change it here - because we are anyhow touching the same code, but If you think it's too much, I am fine to approve it even without it (and you could do it as a follow-up for example).
@Bowrna
Bowrna
commented
Mar 13, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i will add the changes that you have suggested
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
3176485 to
f28a5b7CompareMarch 20, 2024 06:27
@Bowrna
Bowrna
commented
Mar 20, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
potiuk
potiuk
approved these changes
Mar 20, 2024
View reviewed changes
@potiukpotiuk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would love some other committer to take a look - it's quite crucial part of our processing and we had some issues that have been overlooked there in the past - for example #37992
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
Yes. Grace_multiplier is not set anywhere to a different value than default 2.1 now.
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
(or so I saw from reviewing the code myself). It's still good to keep it though in case we have a case we want to override it.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
f28a5b7 to
eef776fCompareMarch 20, 2024 09:19
@BowrnaBowrna
closed this
Mar 20, 2024
@BowrnaBowrna
reopened this
Mar 20, 2024
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
Looks like real issues.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
3 times, most recently
from
2e4b788 to
fd2e4e1CompareMarch 20, 2024 14:54
@Bowrna
Bowrna
commented
Mar 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Test is failing in the health api call testcases. let me debug the issue and fix it by EOD
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
fd2e4e1 to
ddc7d44CompareMarch 21, 2024 08:43
Bowrna
Bowrna
commented
Mar 21, 2024
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
d0b3f94 to
40c4b33CompareApril 4, 2024 06:26
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
40c4b33 to
dda9b36CompareApril 4, 2024 06:43
@Bowrna
Bowrna
commented
Apr 4, 2024

Copy link


Copy Markdown

ContributorAuthor
All green now :)
@potiuk
potiuk
merged commit 6c866f4
into
apache:mainApr 5, 2024
@potiuk
potiuk
commented
Apr 5, 2024

Copy link


Copy Markdown

Member
🎉
@ephraimbuddyephraimbuddy
added
the 
type:improvement
Changelog: Improvements
label
Jun 3, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@potiukpotiukpotiuk approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees


No one assigned


Labels

area:Schedulerincluding HA (high availability) schedulertype:improvementChangelog: Improvements

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Improve log messages of heartbeat connection errors and recovery


5 participants

@Bowrna@potiuk@Lee-W@amoghrajesh@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
heartbeat recovery message  - #34457
Merged
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Apr 5, 2024
Merged
heartbeat recovery message #34457
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Conversation
@Bowrna
@BowrnaBowrna
commented
Sep 18, 2023

Copy link


Copy Markdown

Contributor
related: #31810
closed: #31810
this covers the point C of the issue
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:Scheduler
including HA (high availability) scheduler
label
Sep 18, 2023
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
4 times, most recently
from
df94736 to
55faf46CompareSeptember 19, 2023 07:31
Lee-W
Lee-W
reviewed
Sep 19, 2023
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
5c097d4 to
a33cf10CompareSeptember 21, 2023 17:09
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
a33cf10 to
1730227CompareOctober 1, 2023 04:45
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
d051cb4 to
9d82803CompareOctober 13, 2023 12:35
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
8 times, most recently
from
c21c011 to
54e6c96CompareNovember 1, 2023 07:10
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
54e6c96 to
f77fa86CompareNovember 1, 2023 09:11
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
5 times, most recently
from
0328759 to
139f4aaCompareNovember 2, 2023 04:34
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
984c74c to
dfaaabeCompareDecember 3, 2023 15:27
@potiuk
potiuk
commented
Mar 9, 2024

Copy link


Copy Markdown

Member
this looks good @Bowrna (except the static check failing) - but I have one small proposal. It took me a bit of time to see why grace_multiplier is not passed to to the method in heartbeat - and I found out that even if it is specified in is_alive method, it's never set to anything diffferent than 2.1. And I think it's placed wrrongly. it should not be parameter of is_alive, but it should be - similarly as heartrate for example) added as Job's field in Job's constructor.
self.grace_multiplier = 2.1

And then - it should be taken from job whenever needed (similarly as we take job.job_type).
It would be great to change it here - because we are anyhow touching the same code, but If you think it's too much, I am fine to approve it even without it (and you could do it as a follow-up for example).
@Bowrna
Bowrna
commented
Mar 13, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i will add the changes that you have suggested
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
3176485 to
f28a5b7CompareMarch 20, 2024 06:27
@Bowrna
Bowrna
commented
Mar 20, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
potiuk
potiuk
approved these changes
Mar 20, 2024
View reviewed changes
@potiukpotiuk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would love some other committer to take a look - it's quite crucial part of our processing and we had some issues that have been overlooked there in the past - for example #37992
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
Yes. Grace_multiplier is not set anywhere to a different value than default 2.1 now.
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
(or so I saw from reviewing the code myself). It's still good to keep it though in case we have a case we want to override it.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
f28a5b7 to
eef776fCompareMarch 20, 2024 09:19
@BowrnaBowrna
closed this
Mar 20, 2024
@BowrnaBowrna
reopened this
Mar 20, 2024
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
Looks like real issues.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
3 times, most recently
from
2e4b788 to
fd2e4e1CompareMarch 20, 2024 14:54
@Bowrna
Bowrna
commented
Mar 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Test is failing in the health api call testcases. let me debug the issue and fix it by EOD
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
fd2e4e1 to
ddc7d44CompareMarch 21, 2024 08:43
Bowrna
Bowrna
commented
Mar 21, 2024
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
d0b3f94 to
40c4b33CompareApril 4, 2024 06:26
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
40c4b33 to
dda9b36CompareApril 4, 2024 06:43
@Bowrna
Bowrna
commented
Apr 4, 2024

Copy link


Copy Markdown

ContributorAuthor
All green now :)
@potiuk
potiuk
merged commit 6c866f4
into
apache:mainApr 5, 2024
@potiuk
potiuk
commented
Apr 5, 2024

Copy link


Copy Markdown

Member
🎉
@ephraimbuddyephraimbuddy
added
the 
type:improvement
Changelog: Improvements
label
Jun 3, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@potiukpotiukpotiuk approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees


No one assigned


Labels

area:Schedulerincluding HA (high availability) schedulertype:improvementChangelog: Improvements

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Improve log messages of heartbeat connection errors and recovery


5 participants

@Bowrna@potiuk@Lee-W@amoghrajesh@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
heartbeat recovery message  - #34457
Merged
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Apr 5, 2024
Merged
heartbeat recovery message #34457
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Conversation
@Bowrna
@BowrnaBowrna
commented
Sep 18, 2023

Copy link


Copy Markdown

Contributor
related: #31810
closed: #31810
this covers the point C of the issue
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:Scheduler
including HA (high availability) scheduler
label
Sep 18, 2023
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
4 times, most recently
from
df94736 to
55faf46CompareSeptember 19, 2023 07:31
Lee-W
Lee-W
reviewed
Sep 19, 2023
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
5c097d4 to
a33cf10CompareSeptember 21, 2023 17:09
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
a33cf10 to
1730227CompareOctober 1, 2023 04:45
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
d051cb4 to
9d82803CompareOctober 13, 2023 12:35
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
8 times, most recently
from
c21c011 to
54e6c96CompareNovember 1, 2023 07:10
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
54e6c96 to
f77fa86CompareNovember 1, 2023 09:11
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
5 times, most recently
from
0328759 to
139f4aaCompareNovember 2, 2023 04:34
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
984c74c to
dfaaabeCompareDecember 3, 2023 15:27
@potiuk
potiuk
commented
Mar 9, 2024

Copy link


Copy Markdown

Member
this looks good @Bowrna (except the static check failing) - but I have one small proposal. It took me a bit of time to see why grace_multiplier is not passed to to the method in heartbeat - and I found out that even if it is specified in is_alive method, it's never set to anything diffferent than 2.1. And I think it's placed wrrongly. it should not be parameter of is_alive, but it should be - similarly as heartrate for example) added as Job's field in Job's constructor.
self.grace_multiplier = 2.1

And then - it should be taken from job whenever needed (similarly as we take job.job_type).
It would be great to change it here - because we are anyhow touching the same code, but If you think it's too much, I am fine to approve it even without it (and you could do it as a follow-up for example).
@Bowrna
Bowrna
commented
Mar 13, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i will add the changes that you have suggested
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
3176485 to
f28a5b7CompareMarch 20, 2024 06:27
@Bowrna
Bowrna
commented
Mar 20, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
potiuk
potiuk
approved these changes
Mar 20, 2024
View reviewed changes
@potiukpotiuk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would love some other committer to take a look - it's quite crucial part of our processing and we had some issues that have been overlooked there in the past - for example #37992
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
Yes. Grace_multiplier is not set anywhere to a different value than default 2.1 now.
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
(or so I saw from reviewing the code myself). It's still good to keep it though in case we have a case we want to override it.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
f28a5b7 to
eef776fCompareMarch 20, 2024 09:19
@BowrnaBowrna
closed this
Mar 20, 2024
@BowrnaBowrna
reopened this
Mar 20, 2024
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
Looks like real issues.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
3 times, most recently
from
2e4b788 to
fd2e4e1CompareMarch 20, 2024 14:54
@Bowrna
Bowrna
commented
Mar 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Test is failing in the health api call testcases. let me debug the issue and fix it by EOD
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
fd2e4e1 to
ddc7d44CompareMarch 21, 2024 08:43
Bowrna
Bowrna
commented
Mar 21, 2024
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
d0b3f94 to
40c4b33CompareApril 4, 2024 06:26
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
40c4b33 to
dda9b36CompareApril 4, 2024 06:43
@Bowrna
Bowrna
commented
Apr 4, 2024

Copy link


Copy Markdown

ContributorAuthor
All green now :)
@potiuk
potiuk
merged commit 6c866f4
into
apache:mainApr 5, 2024
@potiuk
potiuk
commented
Apr 5, 2024

Copy link


Copy Markdown

Member
🎉
@ephraimbuddyephraimbuddy
added
the 
type:improvement
Changelog: Improvements
label
Jun 3, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@potiukpotiukpotiuk approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees


No one assigned


Labels

area:Schedulerincluding HA (high availability) schedulertype:improvementChangelog: Improvements

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Improve log messages of heartbeat connection errors and recovery


5 participants

@Bowrna@potiuk@Lee-W@amoghrajesh@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
heartbeat recovery message  - #34457
Merged
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Apr 5, 2024
Merged
heartbeat recovery message #34457
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Conversation
@Bowrna
@BowrnaBowrna
commented
Sep 18, 2023

Copy link


Copy Markdown

Contributor
related: #31810
closed: #31810
this covers the point C of the issue
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:Scheduler
including HA (high availability) scheduler
label
Sep 18, 2023
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
4 times, most recently
from
df94736 to
55faf46CompareSeptember 19, 2023 07:31
Lee-W
Lee-W
reviewed
Sep 19, 2023
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
5c097d4 to
a33cf10CompareSeptember 21, 2023 17:09
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
a33cf10 to
1730227CompareOctober 1, 2023 04:45
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
d051cb4 to
9d82803CompareOctober 13, 2023 12:35
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
8 times, most recently
from
c21c011 to
54e6c96CompareNovember 1, 2023 07:10
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
54e6c96 to
f77fa86CompareNovember 1, 2023 09:11
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
5 times, most recently
from
0328759 to
139f4aaCompareNovember 2, 2023 04:34
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
984c74c to
dfaaabeCompareDecember 3, 2023 15:27
@potiuk
potiuk
commented
Mar 9, 2024

Copy link


Copy Markdown

Member
this looks good @Bowrna (except the static check failing) - but I have one small proposal. It took me a bit of time to see why grace_multiplier is not passed to to the method in heartbeat - and I found out that even if it is specified in is_alive method, it's never set to anything diffferent than 2.1. And I think it's placed wrrongly. it should not be parameter of is_alive, but it should be - similarly as heartrate for example) added as Job's field in Job's constructor.
self.grace_multiplier = 2.1

And then - it should be taken from job whenever needed (similarly as we take job.job_type).
It would be great to change it here - because we are anyhow touching the same code, but If you think it's too much, I am fine to approve it even without it (and you could do it as a follow-up for example).
@Bowrna
Bowrna
commented
Mar 13, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i will add the changes that you have suggested
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
3176485 to
f28a5b7CompareMarch 20, 2024 06:27
@Bowrna
Bowrna
commented
Mar 20, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
potiuk
potiuk
approved these changes
Mar 20, 2024
View reviewed changes
@potiukpotiuk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would love some other committer to take a look - it's quite crucial part of our processing and we had some issues that have been overlooked there in the past - for example #37992
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
Yes. Grace_multiplier is not set anywhere to a different value than default 2.1 now.
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
(or so I saw from reviewing the code myself). It's still good to keep it though in case we have a case we want to override it.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
f28a5b7 to
eef776fCompareMarch 20, 2024 09:19
@BowrnaBowrna
closed this
Mar 20, 2024
@BowrnaBowrna
reopened this
Mar 20, 2024
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
Looks like real issues.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
3 times, most recently
from
2e4b788 to
fd2e4e1CompareMarch 20, 2024 14:54
@Bowrna
Bowrna
commented
Mar 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Test is failing in the health api call testcases. let me debug the issue and fix it by EOD
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
fd2e4e1 to
ddc7d44CompareMarch 21, 2024 08:43
Bowrna
Bowrna
commented
Mar 21, 2024
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
d0b3f94 to
40c4b33CompareApril 4, 2024 06:26
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
40c4b33 to
dda9b36CompareApril 4, 2024 06:43
@Bowrna
Bowrna
commented
Apr 4, 2024

Copy link


Copy Markdown

ContributorAuthor
All green now :)
@potiuk
potiuk
merged commit 6c866f4
into
apache:mainApr 5, 2024
@potiuk
potiuk
commented
Apr 5, 2024

Copy link


Copy Markdown

Member
🎉
@ephraimbuddyephraimbuddy
added
the 
type:improvement
Changelog: Improvements
label
Jun 3, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@potiukpotiukpotiuk approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees


No one assigned


Labels

area:Schedulerincluding HA (high availability) schedulertype:improvementChangelog: Improvements

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Improve log messages of heartbeat connection errors and recovery


5 participants

@Bowrna@potiuk@Lee-W@amoghrajesh@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
heartbeat recovery message  - #34457
Merged
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Apr 5, 2024
Merged
heartbeat recovery message #34457
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Conversation
@Bowrna
@BowrnaBowrna
commented
Sep 18, 2023

Copy link


Copy Markdown

Contributor
related: #31810
closed: #31810
this covers the point C of the issue
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:Scheduler
including HA (high availability) scheduler
label
Sep 18, 2023
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
4 times, most recently
from
df94736 to
55faf46CompareSeptember 19, 2023 07:31
Lee-W
Lee-W
reviewed
Sep 19, 2023
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
5c097d4 to
a33cf10CompareSeptember 21, 2023 17:09
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
a33cf10 to
1730227CompareOctober 1, 2023 04:45
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
d051cb4 to
9d82803CompareOctober 13, 2023 12:35
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
8 times, most recently
from
c21c011 to
54e6c96CompareNovember 1, 2023 07:10
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
54e6c96 to
f77fa86CompareNovember 1, 2023 09:11
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
5 times, most recently
from
0328759 to
139f4aaCompareNovember 2, 2023 04:34
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
984c74c to
dfaaabeCompareDecember 3, 2023 15:27
@potiuk
potiuk
commented
Mar 9, 2024

Copy link


Copy Markdown

Member
this looks good @Bowrna (except the static check failing) - but I have one small proposal. It took me a bit of time to see why grace_multiplier is not passed to to the method in heartbeat - and I found out that even if it is specified in is_alive method, it's never set to anything diffferent than 2.1. And I think it's placed wrrongly. it should not be parameter of is_alive, but it should be - similarly as heartrate for example) added as Job's field in Job's constructor.
self.grace_multiplier = 2.1

And then - it should be taken from job whenever needed (similarly as we take job.job_type).
It would be great to change it here - because we are anyhow touching the same code, but If you think it's too much, I am fine to approve it even without it (and you could do it as a follow-up for example).
@Bowrna
Bowrna
commented
Mar 13, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i will add the changes that you have suggested
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
3176485 to
f28a5b7CompareMarch 20, 2024 06:27
@Bowrna
Bowrna
commented
Mar 20, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
potiuk
potiuk
approved these changes
Mar 20, 2024
View reviewed changes
@potiukpotiuk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would love some other committer to take a look - it's quite crucial part of our processing and we had some issues that have been overlooked there in the past - for example #37992
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
Yes. Grace_multiplier is not set anywhere to a different value than default 2.1 now.
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
(or so I saw from reviewing the code myself). It's still good to keep it though in case we have a case we want to override it.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
f28a5b7 to
eef776fCompareMarch 20, 2024 09:19
@BowrnaBowrna
closed this
Mar 20, 2024
@BowrnaBowrna
reopened this
Mar 20, 2024
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
Looks like real issues.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
3 times, most recently
from
2e4b788 to
fd2e4e1CompareMarch 20, 2024 14:54
@Bowrna
Bowrna
commented
Mar 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Test is failing in the health api call testcases. let me debug the issue and fix it by EOD
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
fd2e4e1 to
ddc7d44CompareMarch 21, 2024 08:43
Bowrna
Bowrna
commented
Mar 21, 2024
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
d0b3f94 to
40c4b33CompareApril 4, 2024 06:26
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
40c4b33 to
dda9b36CompareApril 4, 2024 06:43
@Bowrna
Bowrna
commented
Apr 4, 2024

Copy link


Copy Markdown

ContributorAuthor
All green now :)
@potiuk
potiuk
merged commit 6c866f4
into
apache:mainApr 5, 2024
@potiuk
potiuk
commented
Apr 5, 2024

Copy link


Copy Markdown

Member
🎉
@ephraimbuddyephraimbuddy
added
the 
type:improvement
Changelog: Improvements
label
Jun 3, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@potiukpotiukpotiuk approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees


No one assigned


Labels

area:Schedulerincluding HA (high availability) schedulertype:improvementChangelog: Improvements

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Improve log messages of heartbeat connection errors and recovery


5 participants

@Bowrna@potiuk@Lee-W@amoghrajesh@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
heartbeat recovery message  - #34457
Merged
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Apr 5, 2024
Merged
heartbeat recovery message #34457
potiuk merged 1 commit into
apache:mainfrom 
Bowrna:heartbeat-message-enhancement
Conversation
@Bowrna
@BowrnaBowrna
commented
Sep 18, 2023

Copy link


Copy Markdown

Contributor
related: #31810
closed: #31810
this covers the point C of the issue
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:Scheduler
including HA (high availability) scheduler
label
Sep 18, 2023
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
4 times, most recently
from
df94736 to
55faf46CompareSeptember 19, 2023 07:31
Lee-W
Lee-W
reviewed
Sep 19, 2023
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
5c097d4 to
a33cf10CompareSeptember 21, 2023 17:09
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
a33cf10 to
1730227CompareOctober 1, 2023 04:45
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
d051cb4 to
9d82803CompareOctober 13, 2023 12:35
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
8 times, most recently
from
c21c011 to
54e6c96CompareNovember 1, 2023 07:10
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
54e6c96 to
f77fa86CompareNovember 1, 2023 09:11
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
5 times, most recently
from
0328759 to
139f4aaCompareNovember 2, 2023 04:34
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
984c74c to
dfaaabeCompareDecember 3, 2023 15:27
@potiuk
potiuk
commented
Mar 9, 2024

Copy link


Copy Markdown

Member
this looks good @Bowrna (except the static check failing) - but I have one small proposal. It took me a bit of time to see why grace_multiplier is not passed to to the method in heartbeat - and I found out that even if it is specified in is_alive method, it's never set to anything diffferent than 2.1. And I think it's placed wrrongly. it should not be parameter of is_alive, but it should be - similarly as heartrate for example) added as Job's field in Job's constructor.
self.grace_multiplier = 2.1

And then - it should be taken from job whenever needed (similarly as we take job.job_type).
It would be great to change it here - because we are anyhow touching the same code, but If you think it's too much, I am fine to approve it even without it (and you could do it as a follow-up for example).
@Bowrna
Bowrna
commented
Mar 13, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i will add the changes that you have suggested
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
3176485 to
f28a5b7CompareMarch 20, 2024 06:27
@Bowrna
Bowrna
commented
Mar 20, 2024

Copy link


Copy Markdown

ContributorAuthor
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
potiuk
potiuk
approved these changes
Mar 20, 2024
View reviewed changes
@potiukpotiuk
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would love some other committer to take a look - it's quite crucial part of our processing and we had some issues that have been overlooked there in the past - for example #37992
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
@potiuk i made the changes regarding the grace_multiplier. If I remember right, the grace_multiplier was allowed to be set as a param value in config side and I don't see that part of the code currently. am I missing something here?
Yes. Grace_multiplier is not set anywhere to a different value than default 2.1 now.
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
(or so I saw from reviewing the code myself). It's still good to keep it though in case we have a case we want to override it.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
f28a5b7 to
eef776fCompareMarch 20, 2024 09:19
@BowrnaBowrna
closed this
Mar 20, 2024
@BowrnaBowrna
reopened this
Mar 20, 2024
@potiuk
potiuk
commented
Mar 20, 2024

Copy link


Copy Markdown

Member
Looks like real issues.
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
3 times, most recently
from
2e4b788 to
fd2e4e1CompareMarch 20, 2024 14:54
@Bowrna
Bowrna
commented
Mar 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Test is failing in the health api call testcases. let me debug the issue and fix it by EOD
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
fd2e4e1 to
ddc7d44CompareMarch 21, 2024 08:43
Bowrna
Bowrna
commented
Mar 21, 2024
View reviewed changes
Comment threadairflow/jobs/job.py
Outdated

@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
2 times, most recently
from
d0b3f94 to
40c4b33CompareApril 4, 2024 06:26
@Bowrna
Bowrnaforce-pushed
the
heartbeat-message-enhancement
branch
from
40c4b33 to
dda9b36CompareApril 4, 2024 06:43
@Bowrna
Bowrna
commented
Apr 4, 2024

Copy link


Copy Markdown

ContributorAuthor
All green now :)
@potiuk
potiuk
merged commit 6c866f4
into
apache:mainApr 5, 2024
@potiuk
potiuk
commented
Apr 5, 2024

Copy link


Copy Markdown

Member
🎉
@ephraimbuddyephraimbuddy
added
the 
type:improvement
Changelog: Improvements
label
Jun 3, 2024
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@potiukpotiukpotiuk approved these changes
@kaxilkaxilAwaiting requested review from kaxil
@ashbashbAwaiting requested review from ashb
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees


No one assigned


Labels

area:Schedulerincluding HA (high availability) schedulertype:improvementChangelog: Improvements

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Improve log messages of heartbeat connection errors and recovery


5 participants

@Bowrna@potiuk@Lee-W@amoghrajesh@ephraimbuddy