Uh oh!
There was an error while loading. Please reload this page.
Add more exemptions to lengthy metric list - #34531
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
potiuk
commented
Sep 21, 2023
🎉 Congrats! |
ferruzzi
commented
Sep 22, 2023
Hey, thanks for this one. You are right that the list is a temporary fix, for sure. Just changing the names would be a breaking change though, so it's also done this way for now as a backward-comparability solution. We definitely need a better long-term solution which somehow also maintains back-compat. |
Co-authored-by: Saurabh Kumar <mail@sa1.me> (cherry picked from commit fa6ca5d)
This commit adds more metrics to the set of OTEL metric names which are exempted from max length check. This will temporarily fix the issue that raises exceptions and prevents tasks from running when OTEL metric names are too long.
However it isn't a long-term fix because any new metric added will still have the ability to prevent tasks from running. The long-term fix for this would include shortening the name of all metrics, with information such as
dag_idandtask_idsent to opentelemetry as tags.Relates: #34416
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.