Uh oh!
There was an error while loading. Please reload this page.
Slack: use default_conn_name by default - #34548
Merged
Merged
Conversation
It's convenient not to define connection name if there is only one global or default connection. This is what is usually done in other hooks like `HttpHook`
2 tasks
Taragolis
commented
Sep 22, 2023
Contributor
Nice! I guess you you also need to do the same things in the operators, transfers and notifiers which use SlackHook, to make it consistent. And remove/change this section in to the doc: https://airflow.apache.org/docs/apache-airflow-providers-slack/stable/connections/slack.html#default-connection-ids |
Khrol
marked this pull request as ready for review
September 22, 2023 19:46
hussein-awala
approved these changes
Sep 22, 2023
Taragolis
approved these changes
Sep 22, 2023
98 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's convenient not to define a connection name if there is only one global or default connection.
This is what is usually done in other hooks like
HttpHook.Related discussion: #33557 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.