Uh oh!
There was an error while loading. Please reload this page.
Use ExitStack to manage mutation of secrets_backend_list in dag.test - #34620
Merged
dstandish merged 1 commit intoNov 27, 2023
Merged
Conversation
eladkal
approved these changes
Sep 29, 2023
eladkal
commented
Oct 29, 2023
Contributor
@dstandish needs rebase |
Although it requires another indent, it's cleaner, and more importantly it makes sure that the mutation is undone after failure.
dstandishforce-pushed
the
use-exit-stack-for-sbl-mutation
branch
from
November 27, 2023 15:05
470c087 to
9a88a42Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although it requires another indent, it's cleaner, and more importantly it makes sure that the mutation is undone after failure.