Uh oh!
There was an error while loading. Please reload this page.
Standardise output of "airflow connections export" to those of "airflow variables export" and "airflow users export" - #34640
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
| if file_is_stdout: | ||
| print("\nConnections successfully exported.", file=sys.stderr) | ||
| print(f"\n{len(connections)} connections successfully exported.", file=sys.stderr) |
There was a problem hiding this comment.
@Jayden-Chiu Not a blocker, How can we ensure that the output of export connectionexport variable and users export doesn't mismatch by any further changes in the codebase?
Can we add a single function to prepare a similar output?
There was a problem hiding this comment.
@utkarsharma2 good point, could you open a new PR to do that?
| if file_is_stdout: | ||
| print("\nConnections successfully exported.", file=sys.stderr) | ||
| print(f"\n{len(connections)} connections successfully exported.", file=sys.stderr) |
There was a problem hiding this comment.
@utkarsharma2 good point, could you open a new PR to do that?
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
hussein-awala
commented
Sep 27, 2023
Congrats on your first commit 🎉 |
(cherry picked from commit a5f5e2f)
Output should now be standardized to something similar to users and variables
Closes: #34232
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.