Skip to content

update moto version - #34938

Merged
eladkal merged 1 commit into
apache:mainfrom
eladkal:aws
Oct 15, 2023
Merged

update moto version#34938
eladkal merged 1 commit into
apache:mainfrom
eladkal:aws

Conversation

@eladkal

Copy link
Copy Markdown
Contributor

Following #33956 PR aws/serverless-application-model#3282 has been merged and released in https://github.com/aws/serverless-application-model/releases/tag/v1.75.0 bumping moto to see if the issue is resolved

@eladkaleladkal added this to the Airflow 2.7.3 milestone Oct 14, 2023
@eladkaleladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Oct 14, 2023

@hussein-awalahussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The failed tests and static checks don't seem related to this PR 🤔

@eladkal

Copy link
Copy Markdown
ContributorAuthor

LGTM! The failed tests and static checks don't seem related to this PR 🤔

Yes it will be fixed in #34941

@potiuk

Copy link
Copy Markdown
Member

There are few other tests failing because other dependency releases also caused problems:

WTForms breaking FAB: Workarounded in #34943
Sentry: #34946

I rebased also #34941 on top of the two fixes above and hopefully we will get "green" main again so that you can rebase it.

@potiuk

Copy link
Copy Markdown
Member

Rebased after merging #34941

@eladkal
eladkal merged commit 27443ec into apache:mainOct 15, 2023
@eladkal
eladkal deleted the aws branch October 15, 2023 05:02
potiuk pushed a commit that referenced this pull request Oct 29, 2023
(cherry picked from commit 27443ec)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:misc/internalChangelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@eladkal@potiuk@hussein-awala