Uh oh!
There was an error while loading. Please reload this page.
Better parallellise Other/Operator tests - #35002
Merged
Merged
Conversation
potiuk
requested review from
Taragolis, eladkal, ephraimbuddy, jedcunningham and josh-fell
and removed request for
ashb and jedcunninghamOctober 18, 2023 00:32
potiukforce-pushed
the
better-parallelise-tests
branch
from
October 18, 2023 01:05
250c7d7 to
9023781Comparepotiuk
commented
Oct 18, 2023
MemberAuthor
Looks like this PR speeds up test execution on self-hosted runners from ~20 minutes to 15 minutes. |
MemberAuthor
Failing PROD image will be fixed after #35004 is merged. |
The "test/operators" are one of the longest tests of ours - mainly because of a lot of Python virtualenv operators taking a lot of time to create and tear-down virtualenvs. They contributed a lot to the "Other" category making it one that run for the longest time. In order to improve usage of parallel cores, we separate operator tests to a new "Operators" test typ and let them run in parallel to Other tests - this should help in speeding up the tests overall by around 3-4 minutes on self-hosted runners.
potiukforce-pushed
the
better-parallelise-tests
branch
from
October 18, 2023 08:09
9023781 to
13c1866Compareeladkal
approved these changes
Oct 18, 2023
Taragolis
approved these changes
Oct 18, 2023
potiuk added a commit
that referenced
this pull request
Oct 29, 2023
The "test/operators" are one of the longest tests of ours - mainly because of a lot of Python virtualenv operators taking a lot of time to create and tear-down virtualenvs. They contributed a lot to the "Other" category making it one that run for the longest time. In order to improve usage of parallel cores, we separate operator tests to a new "Operators" test typ and let them run in parallel to Other tests - this should help in speeding up the tests overall by around 3-4 minutes on self-hosted runners. (cherry picked from commit 1b4307b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "test/operators" are one of the longest tests of ours - mainly because of a lot of Python virtualenv operators taking a lot of time to create and tear-down virtualenvs. They contributed a lot to the "Other" category making it one that run for the longest time.
In order to improve usage of parallel cores, we separate operator tests to a new "Operators" test typ and let them run in parallel to Other tests - this should help in speeding up the tests overall by around 3-4 minutes on self-hosted runners.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.