Uh oh!
There was an error while loading. Please reload this page.
Move installed_providers.txt to airflow/providers. - #35081
Merged
Conversation
potiukforce-pushed
the
move-installed-providers
branch
from
October 20, 2023 12:33
ecfe093 to
6cb8a24CompareThe CI scripts in `build-image` workflow are taken from main so when you add new (preinstalled) provider to be installed for PROD image, the provider added in the PR in the file is not present in the build-image workflow. Moving the file to airflow/providers is safe because it does not contain any code - just list of packages that breeze command will use when building the PROD image. Related to #34729
potiukforce-pushed
the
move-installed-providers
branch
from
October 20, 2023 13:10
6cb8a24 to
f3fa3fcComparebolkedebruin
commented
Oct 20, 2023
Contributor
I'm not very at home in this area, but I don't see weird things. If tests pass I'm okay with merging. |
eladkal
approved these changes
Oct 20, 2023
potiuk added a commit
that referenced
this pull request
Oct 29, 2023
The CI scripts in `build-image` workflow are taken from main so when you add new (preinstalled) provider to be installed for PROD image, the provider added in the PR in the file is not present in the build-image workflow. Moving the file to airflow/providers is safe because it does not contain any code - just list of packages that breeze command will use when building the PROD image. Related to #34729 (cherry picked from commit eb76276)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI scripts in
build-imageworkflow are taken from main so when you add new (preinstalled) provider to be installed for PROD image, the provider added in the PR in the file is not present in the build-image workflow. Moving the file to airflow/providers is safe because it does not contain any code - just list of packages that breeze command will use when building the PROD image.Related to #34729
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.