Skip to content

fix: set dry_run to be optional. - #35167

Merged
eladkal merged 5 commits into
apache:mainfrom
austinau:dryrun_fix
Nov 25, 2023
Merged

fix: set dry_run to be optional.#35167
eladkal merged 5 commits into
apache:mainfrom
austinau:dryrun_fix

Conversation

@austinau

@austinauaustinau commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

Fixes#35166. Duplicates the solution in #34568.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Oct 24, 2023
@boring-cyborg

boring-cyborgBot commented Oct 24, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Taragolis
Taragolis reviewed Oct 24, 2023
View reviewed changes
Comment threadtests/api_connexion/schemas/test_task_instance_schema.py Outdated
"task_id": "print_the_context",
}
assert expected_result == result

@TaragolisTaragolisOct 24, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra spaces here, it should be removed for pass Static Checks

@utkarsharma2utkarsharma2Oct 26, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to setup pre-commit hooks - https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst#id12

eladkal
eladkal reviewed Oct 27, 2023
View reviewed changes
Comment threadtests/api_connexion/schemas/test_task_instance_schema.py Outdated
@eladkaleladkal added the type:bug-fix Changelog: Bug Fixes label Oct 27, 2023
@eladkaleladkal added this to the Airflow 2.7.3 milestone Oct 27, 2023
@austinau

austinau commented Oct 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Alright, I removed the whitespace, thanks!

@Calder-Ty

Calder-Ty commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Any update on this PR?

@eladkal
eladkal merged commit 196a235 into apache:mainNov 25, 2023
@boring-cyborg

boring-cyborgBot commented Nov 25, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ephraimbuddy pushed a commit that referenced this pull request Nov 26, 2023
@austinauaustin
@eladkal@ephraimbuddy
fix: set dry_run to be optional. (#35167)
8d2832b
* fix: set dry_run to be optional.
* Update tests/api_connexion/schemas/test_task_instance_schema.py
* Removed extra whitespace.
---------
Co-authored-by: austin <austin.unsicker@advancedmd.com>
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaragolisTaragolisTaragolis left review comments
@utkarsharma2utkarsharma2utkarsharma2 left review comments
@hussein-awalahussein-awalahussein-awala approved these changes
@eladkaleladkaleladkal approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrun

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP APItype:bug-fixChangelog: Bug Fixes

Projects

None yet

Milestone

Airflow 2.8.0

Development

Successfully merging this pull request may close these issues.

dry_run not optional in api for set task instances state

7 participants

@austinau@Calder-Ty@Taragolis@utkarsharma2@hussein-awala@eladkal@ephraimbuddy