Skip to content

Add multiselect to run state in grid view - #35403

Merged
pierrejeambrun merged 8 commits into
apache:mainfrom
vchiapaikeo:vchiapaikeo/k8s-cncf-check-v3
Dec 1, 2023
Merged

Add multiselect to run state in grid view#35403
pierrejeambrun merged 8 commits into
apache:mainfrom
vchiapaikeo:vchiapaikeo/k8s-cncf-check-v3

Conversation

@vchiapaikeo

@vchiapaikeovchiapaikeo commented Nov 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

closes: #34795

multi-select-grid-view.mov
test-search-params.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Nov 3, 2023
@vchiapaikeo
vchiapaikeoforce-pushed the vchiapaikeo/k8s-cncf-check-v3 branch 2 times, most recently from 0897dd3 to b7f5db6CompareNovember 6, 2023 18:25
@bbovenzi

bbovenzi commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Nice. I wonder if listing all of the options by default is the best UX, vs leaving it empty and showing all states.

@vchiapaikeo

vchiapaikeo commented Nov 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Yes, good point. I could even sub it for something like "All Run States". Will get a demo out showing that as well.

Also, what do you think about doing the same for run types? And are you okay with the way it is serialized as a csv with the bulk of the manipulation logic on the JSX side?

@bbovenzi

bbovenzi commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

Yes, good point. I could even sub it for something like "All Run States". Will get a demo out showing that as well.

Also, what do you think about doing the same for run types? And are you okay with the way it is serialized as a csv with the bulk of the manipulation logic on the JSX side?

"All run states" sounds great. Let's do both run state and run type. I think the logic in the PR now looks good.

@vchiapaikeo
vchiapaikeoforce-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from b7f5db6 to b939ef4CompareNovember 18, 2023 02:19
@vchiapaikeo

vchiapaikeo commented Nov 18, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Great. Still need to do some work on tests.

@vchiapaikeo
vchiapaikeoforce-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from b939ef4 to 7ef33e0CompareNovember 18, 2023 13:22
@vchiapaikeo

vchiapaikeo commented Nov 18, 2023

Copy link
Copy Markdown
ContributorAuthor

Latest demo:

multiselect-demo2.mov

@potiuk

potiuk commented Nov 18, 2023

Copy link
Copy Markdown
Member

Nice!

@vchiapaikeo
vchiapaikeoforce-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from b77aa83 to b98dfcaCompareNovember 19, 2023 16:12
eladkal
eladkal approved these changes Nov 21, 2023
View reviewed changes

@eladkaleladkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@eladkaleladkal added this to the Airflow 2.8.0 milestone Nov 24, 2023
@eladkaleladkal added the type:improvement Changelog: Improvements label Nov 24, 2023
@eladkal

eladkal commented Nov 24, 2023

Copy link
Copy Markdown
Contributor

cc @bbovenzi can we merge?

pierrejeambrun
pierrejeambrun reviewed Nov 26, 2023
View reviewed changes
Comment threadairflow/www/views.py Outdated
bbovenzi
bbovenzi approved these changes Nov 27, 2023
View reviewed changes

@bbovenzibbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS code looks good

vchiapaikeo
vchiapaikeo commented Nov 29, 2023
View reviewed changes
Comment threadairflow/www/static/js/api/useGridData.ts Outdated
@vchiapaikeo
vchiapaikeoforce-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from 0fa54a4 to 2a4d949CompareNovember 29, 2023 15:08
@vchiapaikeo

vchiapaikeo commented Nov 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Latest demo:

multiselect.mov

@vchiapaikeo

vchiapaikeo commented Dec 1, 2023

Copy link
Copy Markdown
ContributorAuthor

I think we are good to merge here.

@vchiapaikeo
vchiapaikeoforce-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from 2a4d949 to 777580fCompareDecember 1, 2023 14:48
@pierrejeambrun

pierrejeambrun commented Dec 1, 2023

Copy link
Copy Markdown
Member

Nice, thank you!

@pierrejeambrun
pierrejeambrun merged commit 9e28475 into apache:mainDec 1, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
@vchiapaikeo@ephraimbuddy
Add multiselect to run state in grid view (#35403)
4652d7f
* Add multiselect to run state in grid view
* Fix tests
* Multiselect for run types, UI nits, refactor
* Fix tests, refactor
* Simplify multiselect value
* Nits and refactor
* Use arrays instead of serializing to csv
* Fix tests and global axios paramsSerializer to null
(cherry picked from commit 9e28475)
@potiukpotiuk mentioned this pull request Dec 11, 2023
Merged
@sean-rosesean-rose mentioned this pull request Mar 1, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@eladkaleladkaleladkal approved these changes
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@ashbashbAwaiting requested review from ashb
@potiukpotiukAwaiting requested review from potiuk
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees

No one assigned

Labels

area:UIRelated to UI/UX. For Frontend Developers.area:webserverWebserver related Issuestype:improvementChangelog: Improvements

Projects

None yet

Milestone

Airflow 2.8.0

Development

Successfully merging this pull request may close these issues.

Support multi-select state filtering on grid view

5 participants

@vchiapaikeo@bbovenzi@potiuk@eladkal@pierrejeambrun