Support configuring multiple namespace for multiNamespaceMode by hussein-awala · Pull Request #35639 · apache/airflow

hussein-awala · 2023-11-14T23:18:35Z

This PR adds a new value, airflowNamespaces to create some resources usually used by the K8S worker/K8S pod when creating them in another namespace.

I'm trying to refactorize the method:

{{- $workersNamespaces := list }}
{{- if .Values.multiNamespaceMode }}
{{- range $namespace := .Values.airflowNamespaces }}
{{- $workersNamespaces = mustAppend $workersNamespaces ($namespace | quote) }}
{{- end }}
{{- end }}
{{- if not (has (.Release.Namespace | quote) $workersNamespaces) }}
{{ $workersNamespaces = mustPrepend $workersNamespaces (.Release.Namespace | quote) }}
{{- end }}

and move it to _helpers, but I have a problem with the returned value (string), which is badly parsed in the templates.

shohamy7 · 2023-12-18T22:58:46Z

Hi! @hussein-awala
I am interested in this PR, so I will try to help :)
I encountered the problem with returning list from define in the past, it seems like it's not possible as define helpers only returns strings.
Maybe you can workaround this issue by converting the list to and from json as suggested in the following SO issue: https://stackoverflow.com/questions/77438391/return-a-list-variable-from-a-helm-helper-function
It seems a bit hacky but it does the trick.
Let me know what you think!

github-actions · 2024-02-02T00:11:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-03-23T00:11:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-12-07T00:17:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-02-05T00:15:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-04-04T00:16:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

hussein-awala · 2023-11-14T23:18:35Z

This PR adds a new value, airflowNamespaces to create some resources usually used by the K8S worker/K8S pod when creating them in another namespace.

I'm trying to refactorize the method:

{{- $workersNamespaces := list }}
{{- if .Values.multiNamespaceMode }}
{{- range $namespace := .Values.airflowNamespaces }}
{{- $workersNamespaces = mustAppend $workersNamespaces ($namespace | quote) }}
{{- end }}
{{- end }}
{{- if not (has (.Release.Namespace | quote) $workersNamespaces) }}
{{ $workersNamespaces = mustPrepend $workersNamespaces (.Release.Namespace | quote) }}
{{- end }}

and move it to _helpers, but I have a problem with the returned value (string), which is badly parsed in the templates.

shohamy7 · 2023-12-18T22:58:46Z

Hi! @hussein-awala
I am interested in this PR, so I will try to help :)
I encountered the problem with returning list from define in the past, it seems like it's not possible as define helpers only returns strings.
Maybe you can workaround this issue by converting the list to and from json as suggested in the following SO issue: https://stackoverflow.com/questions/77438391/return-a-list-variable-from-a-helm-helper-function
It seems a bit hacky but it does the trick.
Let me know what you think!

github-actions · 2024-02-02T00:11:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-03-23T00:11:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-12-07T00:17:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-02-05T00:15:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-04-04T00:16:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

hussein-awala · 2023-11-14T23:18:35Z

This PR adds a new value, airflowNamespaces to create some resources usually used by the K8S worker/K8S pod when creating them in another namespace.

I'm trying to refactorize the method:

{{- $workersNamespaces := list }}
{{- if .Values.multiNamespaceMode }}
{{- range $namespace := .Values.airflowNamespaces }}
{{- $workersNamespaces = mustAppend $workersNamespaces ($namespace | quote) }}
{{- end }}
{{- end }}
{{- if not (has (.Release.Namespace | quote) $workersNamespaces) }}
{{ $workersNamespaces = mustPrepend $workersNamespaces (.Release.Namespace | quote) }}
{{- end }}

and move it to _helpers, but I have a problem with the returned value (string), which is badly parsed in the templates.

shohamy7 · 2023-12-18T22:58:46Z

Hi! @hussein-awala
I am interested in this PR, so I will try to help :)
I encountered the problem with returning list from define in the past, it seems like it's not possible as define helpers only returns strings.
Maybe you can workaround this issue by converting the list to and from json as suggested in the following SO issue: https://stackoverflow.com/questions/77438391/return-a-list-variable-from-a-helm-helper-function
It seems a bit hacky but it does the trick.
Let me know what you think!

github-actions · 2024-02-02T00:11:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-03-23T00:11:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-12-07T00:17:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-02-05T00:15:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-04-04T00:16:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

hussein-awala · 2023-11-14T23:18:35Z

This PR adds a new value, airflowNamespaces to create some resources usually used by the K8S worker/K8S pod when creating them in another namespace.

I'm trying to refactorize the method:

{{- $workersNamespaces := list }}
{{- if .Values.multiNamespaceMode }}
{{- range $namespace := .Values.airflowNamespaces }}
{{- $workersNamespaces = mustAppend $workersNamespaces ($namespace | quote) }}
{{- end }}
{{- end }}
{{- if not (has (.Release.Namespace | quote) $workersNamespaces) }}
{{ $workersNamespaces = mustPrepend $workersNamespaces (.Release.Namespace | quote) }}
{{- end }}

and move it to _helpers, but I have a problem with the returned value (string), which is badly parsed in the templates.

shohamy7 · 2023-12-18T22:58:46Z

Hi! @hussein-awala
I am interested in this PR, so I will try to help :)
I encountered the problem with returning list from define in the past, it seems like it's not possible as define helpers only returns strings.
Maybe you can workaround this issue by converting the list to and from json as suggested in the following SO issue: https://stackoverflow.com/questions/77438391/return-a-list-variable-from-a-helm-helper-function
It seems a bit hacky but it does the trick.
Let me know what you think!

github-actions · 2024-02-02T00:11:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-03-23T00:11:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-12-07T00:17:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-02-05T00:15:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-04-04T00:16:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

hussein-awala · 2023-11-14T23:18:35Z

This PR adds a new value, airflowNamespaces to create some resources usually used by the K8S worker/K8S pod when creating them in another namespace.

I'm trying to refactorize the method:

{{- $workersNamespaces := list }}
{{- if .Values.multiNamespaceMode }}
{{- range $namespace := .Values.airflowNamespaces }}
{{- $workersNamespaces = mustAppend $workersNamespaces ($namespace | quote) }}
{{- end }}
{{- end }}
{{- if not (has (.Release.Namespace | quote) $workersNamespaces) }}
{{ $workersNamespaces = mustPrepend $workersNamespaces (.Release.Namespace | quote) }}
{{- end }}

and move it to _helpers, but I have a problem with the returned value (string), which is badly parsed in the templates.

shohamy7 · 2023-12-18T22:58:46Z

Hi! @hussein-awala
I am interested in this PR, so I will try to help :)
I encountered the problem with returning list from define in the past, it seems like it's not possible as define helpers only returns strings.
Maybe you can workaround this issue by converting the list to and from json as suggested in the following SO issue: https://stackoverflow.com/questions/77438391/return-a-list-variable-from-a-helm-helper-function
It seems a bit hacky but it does the trick.
Let me know what you think!

github-actions · 2024-02-02T00:11:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-03-23T00:11:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-12-07T00:17:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-02-05T00:15:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-04-04T00:16:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

hussein-awala · 2023-11-14T23:18:35Z

This PR adds a new value, airflowNamespaces to create some resources usually used by the K8S worker/K8S pod when creating them in another namespace.

I'm trying to refactorize the method:

{{- $workersNamespaces := list }}
{{- if .Values.multiNamespaceMode }}
{{- range $namespace := .Values.airflowNamespaces }}
{{- $workersNamespaces = mustAppend $workersNamespaces ($namespace | quote) }}
{{- end }}
{{- end }}
{{- if not (has (.Release.Namespace | quote) $workersNamespaces) }}
{{ $workersNamespaces = mustPrepend $workersNamespaces (.Release.Namespace | quote) }}
{{- end }}

and move it to _helpers, but I have a problem with the returned value (string), which is badly parsed in the templates.

shohamy7 · 2023-12-18T22:58:46Z

Hi! @hussein-awala
I am interested in this PR, so I will try to help :)
I encountered the problem with returning list from define in the past, it seems like it's not possible as define helpers only returns strings.
Maybe you can workaround this issue by converting the list to and from json as suggested in the following SO issue: https://stackoverflow.com/questions/77438391/return-a-list-variable-from-a-helm-helper-function
It seems a bit hacky but it does the trick.
Let me know what you think!

github-actions · 2024-02-02T00:11:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-03-23T00:11:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-12-07T00:17:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-02-05T00:15:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-04-04T00:16:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

hussein-awala · 2023-11-14T23:18:35Z

This PR adds a new value, airflowNamespaces to create some resources usually used by the K8S worker/K8S pod when creating them in another namespace.

I'm trying to refactorize the method:

{{- $workersNamespaces := list }}
{{- if .Values.multiNamespaceMode }}
{{- range $namespace := .Values.airflowNamespaces }}
{{- $workersNamespaces = mustAppend $workersNamespaces ($namespace | quote) }}
{{- end }}
{{- end }}
{{- if not (has (.Release.Namespace | quote) $workersNamespaces) }}
{{ $workersNamespaces = mustPrepend $workersNamespaces (.Release.Namespace | quote) }}
{{- end }}

and move it to _helpers, but I have a problem with the returned value (string), which is badly parsed in the templates.

shohamy7 · 2023-12-18T22:58:46Z

Hi! @hussein-awala
I am interested in this PR, so I will try to help :)
I encountered the problem with returning list from define in the past, it seems like it's not possible as define helpers only returns strings.
Maybe you can workaround this issue by converting the list to and from json as suggested in the following SO issue: https://stackoverflow.com/questions/77438391/return-a-list-variable-from-a-helm-helper-function
It seems a bit hacky but it does the trick.
Let me know what you think!

github-actions · 2024-02-02T00:11:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-03-23T00:11:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-12-07T00:17:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-02-05T00:15:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-04-04T00:16:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

hussein-awala · 2023-11-14T23:18:35Z

This PR adds a new value, airflowNamespaces to create some resources usually used by the K8S worker/K8S pod when creating them in another namespace.

I'm trying to refactorize the method:

{{- $workersNamespaces := list }}
{{- if .Values.multiNamespaceMode }}
{{- range $namespace := .Values.airflowNamespaces }}
{{- $workersNamespaces = mustAppend $workersNamespaces ($namespace | quote) }}
{{- end }}
{{- end }}
{{- if not (has (.Release.Namespace | quote) $workersNamespaces) }}
{{ $workersNamespaces = mustPrepend $workersNamespaces (.Release.Namespace | quote) }}
{{- end }}

and move it to _helpers, but I have a problem with the returned value (string), which is badly parsed in the templates.

shohamy7 · 2023-12-18T22:58:46Z

Hi! @hussein-awala
I am interested in this PR, so I will try to help :)
I encountered the problem with returning list from define in the past, it seems like it's not possible as define helpers only returns strings.
Maybe you can workaround this issue by converting the list to and from json as suggested in the following SO issue: https://stackoverflow.com/questions/77438391/return-a-list-variable-from-a-helm-helper-function
It seems a bit hacky but it does the trick.
Let me know what you think!

github-actions · 2024-02-02T00:11:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-03-23T00:11:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2024-12-07T00:17:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-02-05T00:15:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

github-actions · 2025-04-04T00:16:46Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

Support configuring multiple namespace for multiNamespaceMode
04e0124

boring-cyborgBot added the area:helm-chart Airflow Helm Chart label Nov 14, 2023

hussein-awala mentioned this pull request Nov 23, 2023
Fix K8S executor override config using pod_override_object #35185
Merged

eladkal mentioned this pull request Jan 7, 2024
Launch Pod/job in separate namespace and support in helm chart #25222
Open
2 tasks

eladkal linked an issue Jan 7, 2024 that may be closed by this pull request
Launch Pod/job in separate namespace and support in helm chart #25222
Open
2 tasks

github-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 2, 2024

eladkal mentioned this pull request Feb 6, 2024
Chart: Fix cluster-wide RBAC naming clash when using multiple multiNamespace releases with the same name #37197
Merged

hussein-awala removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 6, 2024

github-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 23, 2024

github-actionsBot closed this Mar 29, 2024

eladkal mentioned this pull request Aug 20, 2024
Multiple Airflow in one k8s namespace #41608
Closed
2 tasks

shahar1 removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 27, 2024

shahar1 reopened this Sep 27, 2024

github-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 7, 2024

github-actionsBot closed this Dec 16, 2024

shahar1 reopened this Dec 17, 2024

github-actionsBot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 18, 2024

github-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 5, 2025

github-actionsBot closed this Feb 12, 2025

shahar1 removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 17, 2025

shahar1 reopened this Feb 17, 2025

github-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 4, 2025

github-actionsBot closed this Apr 9, 2025