Uh oh!
There was an error while loading. Please reload this page.
improved visibility of tasks in ActionModal for taskInstance - #35810
Merged
Conversation
theaadya
requested review from
ashb, bbovenzi, pierrejeambrun and ryanahamilton
as code ownersNovember 23, 2023 06:32
bbovenzi
approved these changes
Nov 27, 2023
ephraimbuddy pushed a commit
that referenced
this pull request
Dec 5, 2023
* change max box height in ActionModal.tsx * changed max box height in ActionModal.tsx (cherry picked from commit 9a1dceb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ActionModal (for both Clear and Mark as Success/Failed) for taskInstance wasn't completely visible on my screen when several tasks were present. Adjusted the maximum box height according to screen size.
Before
After
