Skip to content

Move pre-commit for local-file-mounts to breeze shell - #35878

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:move-pre-commit-local-mounts-sync-to-breeze-shell
Nov 27, 2023
Merged

Move pre-commit for local-file-mounts to breeze shell #35878
potiuk merged 1 commit into
apache:mainfrom
potiuk:move-pre-commit-local-mounts-sync-to-breeze-shell

Conversation

@potiuk

Copy link
Copy Markdown
Member

The pre-commit is moved to be run via breeze shell. The code to do
so has been migrated to new breeze command.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk

Copy link
Copy Markdown
MemberAuthor

Based on #35875

@potiuk
potiukforce-pushed the move-pre-commit-local-mounts-sync-to-breeze-shell branch from a6d2f0b to 522c5c2CompareNovember 27, 2023 02:38
@potiuk
potiukforce-pushed the move-pre-commit-local-mounts-sync-to-breeze-shell branch from 522c5c2 to 50c79d8CompareNovember 27, 2023 03:19

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, small nits

Comment threadBREEZE.rst Outdated
Comment threadscripts/ci/pre_commit/pre_commit_local_yml_mounts.py Outdated
@potiukpotiuk added the debug ci resources Set it on PR if you want to debug resource usage for it label Nov 27, 2023
The pre-commit is moved to be run via breeze shell. The code to do
so has been migrated to new breeze command.
@potiuk
potiukforce-pushed the move-pre-commit-local-mounts-sync-to-breeze-shell branch from 50c79d8 to 548abc7CompareNovember 27, 2023 10:23
@potiuk

Copy link
Copy Markdown
MemberAuthor

Same here another #35830 off-spring

@potiuk
potiuk merged commit 07e40bd into apache:mainNov 27, 2023
@potiuk
potiuk deleted the move-pre-commit-local-mounts-sync-to-breeze-shell branch November 27, 2023 16:43
potiuk added a commit that referenced this pull request Dec 15, 2023
The pre-commit is moved to be run via breeze shell. The code to do
so has been migrated to new breeze command.
(cherry picked from commit 07e40bd)
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 15, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-toolschangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)debug ci resourcesSet it on PR if you want to debug resource usage for itkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@potiuk@amoghrajesh@ephraimbuddy