Skip to content

Bump minimum Airflow version in providers to Airflow 2.6.0 - #36017

Merged
eladkal merged 5 commits into
apache:mainfrom
eladkal:bump
Dec 7, 2023
Merged

Bump minimum Airflow version in providers to Airflow 2.6.0#36017
eladkal merged 5 commits into
apache:mainfrom
eladkal:bump

Conversation

@eladkal

Copy link
Copy Markdown
Contributor

Note: suspended providers are not included in bump min airflow version (daskexecutor provider)

@eladkal
eladkal requested a review from kaxil as a code ownerDecember 1, 2023 19:54
@potiuk

Copy link
Copy Markdown
Member

Interesting error with providers. It looks like (Can't remember that) Airflow 2.6.0 had "apache-airflow-providers-hive" dependency instead of "apache-airflow-providers-apache-hive". But it seems that 2.6.1 has it fixed already - so just setting

--use-airflow-version 2.6.1

should fix the issue.

Comment thread.github/workflows/ci.yml Outdated
Comment thread.github/workflows/ci.yml Outdated
Comment thread.github/workflows/ci.yml Outdated
Comment thread.github/workflows/ci.yml Outdated
@potiuk

potiuk commented Dec 2, 2023

Copy link
Copy Markdown
Member

Ok. Two fixes are needed:

  1. rm -rf dist/apache_airflow_providers_cohere*.whl - added here:
    rm -rf dist/apache_airflow_providers_common_io*.whl

With the comment that is should be removed when we bump to 2.7.1

  1. add min_airflow_version = 2.7.1 for cohere provider - seems that importlib limitation in airflow (<5) is incompatible with cohere's (>=6) - and it was only removed in 2.7.1 (Fix dependencies for celery and opentelemetry for Python 3.8 #33579)

So looks ike Cohere provider is only actually installable for Airflow 2.7.1+ - we should add in their provider.yaml

@eladkal

Copy link
Copy Markdown
ContributorAuthor

add min_airflow_version = 2.7.1 for cohere provider - seems that importlib limitation in airflow (<5) is incompatible with cohere's (>=6) - and it was only removed in 2.7.1 (#3357)

I think the PR you linked is wrong?
Why do you claim that cohere provider needs Airflow>=2.7.1?
I don't see anything binding that provider to newer core versions (unlike common.fs)

@eladkal

Copy link
Copy Markdown
ContributorAuthor

The cohere provider can't work with Airflow 2.6 unless using Python 3.9 due to version of importlib

OK thanks to @potiuk we may have workaround for this

8ad4e9b

@eladkal
eladkalforce-pushed the bump branch 2 times, most recently from 82c258c to 7069f0bCompareDecember 3, 2023 20:20
@potiuk

Copy link
Copy Markdown
Member

Seems like we are havin issue with just released 0.23.1 of Pytest-asyncio, which was supposed to fix bugs in (also just released but 10 hours earlier). I opened an issue pytest-dev/pytest-asyncio#703 to ask what's going on.

@potiuk

Copy link
Copy Markdown
Member

And PR here to temporarily limit asyncio until we know whats going on #36037

@eladkal
eladkalforce-pushed the bump branch 2 times, most recently from 8fe1107 to bdec307CompareDecember 6, 2023 07:32
@eladkal

Copy link
Copy Markdown
ContributorAuthor

rebased after #36061
lets see if CI passes

@potiuk

Copy link
Copy Markdown
Member

rebased after #36061 lets see if CI passes

Close enough - you need to also remove 2.5.0 from the list :

https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#bump-min-airflow-version-for-providers

Update BASE_PROVIDERS_COMPATIBILITY_CHECKS in src/airflow_breeze/global_constants.py to remove the versions of Airflow that are not applicable any more.

@eladkal

Copy link
Copy Markdown
ContributorAuthor

Close enough - you need to also remove 2.5.0 from the list

Thanks! I new i forgot something

@potiuk

Copy link
Copy Markdown
Member

Looks good :)

@eladkal
eladkal merged commit d0918d7 into apache:mainDec 7, 2023
@eladkal
eladkal deleted the bump branch December 7, 2023 03:25
@ephraimbuddy

Copy link
Copy Markdown
Contributor

This should be in 2.8 right @eladkal ?

@eladkal

Copy link
Copy Markdown
ContributorAuthor

This should be in 2.8 right @eladkal ?

If the breeze changes are relevant yes.

@eladkaleladkal added this to the Airflow 2.8.0 milestone Dec 7, 2023
@eladkaleladkal added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 7, 2023
@ephraimbuddy

Copy link
Copy Markdown
Contributor

This should be in 2.8 right @eladkal ?

If the breeze changes are relevant yes.

I think it popped up because of the generated/ folder. I will try cherry-picking it

@potiuk

Copy link
Copy Markdown
Member

I think it's not strictly necessary for 2.8 - I will cherry-pick it eventually anyway (if @ephraimbuddy will not do it ) - but for 2.8.0 (i will eventually make it completely uneccessary when we move to more modern tooling for building airflow package ~ couple of months or so.

potiuk pushed a commit that referenced this pull request Dec 15, 2023
* Bump minimum Airflow version in providers to Airflow 2.6.0
* Fix breeze unit tests
* Handle cohere provider
* enhance CI matrix for provider-airflow-compatibility-check
* remove 2.5.0 from BASE_PROVIDERS_COMPATIBILITY_CHECKS
(cherry picked from commit d0918d7)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@eladkal@potiuk@ephraimbuddy@Taragolis@hussein-awala@josh-fell