Skip to content

Use dropdown instead of buttons when there are more than 10 retries in log tab - #36025

Merged
potiuk merged 2 commits into
apache:mainfrom
tirkarthi:log-high-retries
Dec 3, 2023
Merged

Use dropdown instead of buttons when there are more than 10 retries in log tab#36025
potiuk merged 2 commits into
apache:mainfrom
tirkarthi:log-high-retries

Conversation

@tirkarthi

Copy link
Copy Markdown
Contributor

Use dropdown instead of button to select log attempt when there are more than 10 retries.

Less than 10 retries

image

More than 10 retries

image

closes: #35889
related: #35889

Sample dag :

fromdatetimeimportdatetime, timedeltafromairflowimportDAGfromairflow.decoratorsimporttaskwithDAG(
dag_id="retry_issue_dag",
start_date=datetime(2023, 10, 10),
catchup=False,
schedule_interval="@once",
) asdag:
@task(retries=8, retry_delay=timedelta(seconds=1))defretry_less_than_10():
raiseException("fail")
@task(retries=15, retry_delay=timedelta(seconds=1))defretry_more_than_10():
raiseException("fail")
retry_less_than_10()
retry_more_than_10()

@boring-cyborgboring-cyborgBot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Dec 2, 2023
@eladkaleladkal added this to the Airflow 2.8.0 milestone Dec 2, 2023
@eladkaleladkal added the type:bug-fix Changelog: Bug Fixes label Dec 2, 2023
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
@potiuk
potiuk merged commit fd09883 into apache:mainDec 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
…n log tab (#36025)
* Use dropdown instead of buttons when there are more than 10 retries in log tab.
* Update airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
---------
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
(cherry picked from commit fd09883)
@ephraimbuddyephraimbuddy added type:new-feature Changelog: New Features and removed type:bug-fix Changelog: Bug Fixes labels Dec 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.area:webserverWebserver related Issuestype:new-featureChangelog: New Features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New logs tab is broken for tasks with high retries

5 participants

@tirkarthi@potiuk@eladkal@jscheffl@ephraimbuddy