Skip to content

Change Trigger UI to use HTTP POST in web ui - #36026

Merged
jscheffl merged 3 commits into
apache:mainfrom
boschglobal:feature/switch-trigger-call-to-post-in-ui
Dec 2, 2023
Merged

Change Trigger UI to use HTTP POST in web ui#36026
jscheffl merged 3 commits into
apache:mainfrom
boschglobal:feature/switch-trigger-call-to-post-in-ui

Conversation

@jscheffl

@jscheffljscheffl commented Dec 2, 2023

Copy link
Copy Markdown
Contributor

This PR changes the web UI trigger form to be shown always when calling via GET. Before it was possible to "accidentally" make a trigger when no form parameters were specified in a DAG and you passed the trigger URL along.

Now the UI uses POST when clicking.

How to test:

  • Open your test env on the branch and run it via breeze on this branch
  • Open the UI and log-in with your user
  • Use the same window keeping the login context and call http://localhost:28080/dags/dataset_produces_1/trigger with the browser and see the trigger form popping up (Which in main will directly execute a trigger)

@boring-cyborgboring-cyborgBot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Dec 2, 2023
@jscheffljscheffl added this to the Airflow 2.8.0 milestone Dec 2, 2023
ashb
ashb approved these changes Dec 2, 2023
View reviewed changes
potiuk
potiuk reviewed Dec 2, 2023
View reviewed changes

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as well.

@jscheffl
jscheffl merged commit f5d8027 into apache:mainDec 2, 2023
@ephraimbuddyephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Dec 5, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
@jscheffl@ephraimbuddy
Change Trigger UI to use HTTP POST in web ui (#36026)
d6ce328
* Change Trigger UI to use HTTP POST in web ui, GET always shows trigger form
* Adjust tests to changed behavior of trigger handling, expects data submitted in POST
(cherry picked from commit f5d8027)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashbashbashb approved these changes
@potiukpotiukpotiuk approved these changes
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@bbovenzibbovenziAwaiting requested review from bbovenzi
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrun

Assignees

No one assigned

Labels

area:UIRelated to UI/UX. For Frontend Developers.area:webserverWebserver related Issuestype:bug-fixChangelog: Bug Fixes

Projects

None yet

Milestone

Airflow 2.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jscheffl@ashb@potiuk@ephraimbuddy