Uh oh!
There was an error while loading. Please reload this page.
Revert "Add a public interface for custom weight_rule implementation (#35210)" - #36066
Merged
Conversation
hussein-awala
requested review from
XD-DENG, ashb, bbovenzi, bolkedebruin, ephraimbuddy, kaxil, o-nikolas, pierrejeambrun, potiuk, ryanahamilton and uranusjr
as code ownersDecember 5, 2023 10:48
hussein-awala
marked this pull request as draft
December 5, 2023 10:52
potiuk
approved these changes
Dec 5, 2023
ephraimbuddy
marked this pull request as ready for review
December 6, 2023 06:47
ephraimbuddy
commented
Dec 6, 2023
Contributor
Any objection to merging this now? |
ephraimbuddy
commented
Dec 6, 2023
Contributor
I tried to drop the commit from 2-8-test but there are conflicts. Merging this and cherry-picking to 2-8-test seems a better solution |
hussein-awala
commented
Dec 6, 2023
MemberAuthor
No, I will duplicate the original commit in my second PR, and try to finish it before Monday. |
ephraimbuddy pushed a commit
that referenced
this pull request
Dec 6, 2023
hussein-awala added a commit
to hussein-awala/airflow
that referenced
this pull request
Dec 6, 2023
…ntation (apache#35210)" (apache#36066)" This reverts commit f60d458.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3385113.
To avoid introducing a new security issue, we've decided to merge #36029 in 2.8.0 if it's ready or revert #35210 and wait for 2.9.0 to have the complete implementation.
For more details: #35210 (comment)