Skip to content

fix datetime reference in DAG.is_fixed_time_schedule - #36370

Merged
hussein-awala merged 1 commit into
apache:mainfrom
joshowen:patch-1
Dec 22, 2023
Merged

fix datetime reference in DAG.is_fixed_time_schedule#36370
hussein-awala merged 1 commit into
apache:mainfrom
joshowen:patch-1

Conversation

@joshowen

@joshowenjoshowen commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

Fixes a bug in is_fixed_time_schedule due to imports


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@dirraodirrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshowen
Thanks for the MR. I see this function is marked as deprecated and not being referenced anywhere in the code. Do we need to support this function?

@joshowen

joshowen commented Dec 22, 2023

Copy link
Copy Markdown
ContributorAuthor

@joshowen Thanks for the MR. I see this function is marked as deprecated and not being referenced anywhere in the code. Do we need to support this function?

The deprecation warning says it isn't being removed until Airflow3, so I think its reasonable to expect it to continue to exist and work.

@joshowen
joshowen marked this pull request as ready for review December 22, 2023 17:01

@dirraodirrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hussein-awalahussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hussein-awala

Copy link
Copy Markdown
Member

related to #35887

@hussein-awala

Copy link
Copy Markdown
Member

@joshowen Thanks for the MR. I see this function is marked as deprecated and not being referenced anywhere in the code. Do we need to support this function?

When we deprecate a method/feature, we stop adding new features and improvements to it, but we should maintain it and fix its bugs, especially since this method was broken in the last release.

@hussein-awala
hussein-awala merged commit 547ddf6 into apache:mainDec 22, 2023
@boring-cyborg

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@hussein-awala

Copy link
Copy Markdown
Member

Congrats on your first commit 🎉

@ephraimbuddyephraimbuddy added this to the Airflow 2.8.1 milestone Jan 10, 2024
@ephraimbuddyephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jan 10, 2024
ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joshowen@hussein-awala@dirrao@ephraimbuddy