Uh oh!
There was an error while loading. Please reload this page.
feat: add Yandex Cloud Lockbox secrets backend - #36449
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
5ad5fe4 to
57d0d35Compare
Taragolis
left a comment
There was a problem hiding this comment.
I'm not familiar with with Yandex.Cloud and sdk so this is just some generic comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
57d0d35 to
158dc82Compare158dc82 to
b6e8787Compareb6e8787 to
defbc56Compare
Piatachock
left a comment
There was a problem hiding this comment.
Almost LGTM. Mostly nit-s, endpoint parameter is important tho.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aa31fb2 to
b1ce06eCompare
Taragolis
left a comment
There was a problem hiding this comment.
My main concern about Connection ID into the Secrets Manager, see appropriate conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
b1ce06e to
e0acf30Comparee0acf30 to
be6f387CompareImpressionableRaccoon
commented
Jan 22, 2024
I think it's ready to merge |
be6f387 to
2622b59CompareAwesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This PR added support for Yandex Cloud Lockbox secrets backend to Yandex Cloud provider 😎
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.