Skip to content

feat: add Yandex Cloud Lockbox secrets backend - #36449

Merged
Taragolis merged 4 commits into
apache:mainfrom
ImpressionableRaccoon:add-lockbox-secrets-backend
Jan 25, 2024
Merged

feat: add Yandex Cloud Lockbox secrets backend#36449
Taragolis merged 4 commits into
apache:mainfrom
ImpressionableRaccoon:add-lockbox-secrets-backend

Conversation

@ImpressionableRaccoon

Copy link
Copy Markdown
Contributor

This PR added support for Yandex Cloud Lockbox secrets backend to Yandex Cloud provider 😎


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Comment threadairflow/providers/yandex/CHANGELOG.rst Outdated
Comment threadairflow/providers/yandex/provider.yaml Outdated
Comment threadairflow/providers/yandex/provider.yaml Outdated
@ImpressionableRaccoon
ImpressionableRaccoonforce-pushed the add-lockbox-secrets-backend branch 3 times, most recently from 5ad5fe4 to 57d0d35CompareDecember 27, 2023 10:57

@TaragolisTaragolis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with with Yandex.Cloud and sdk so this is just some generic comments

Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadtests/providers/yandex/secrets/test_secrets_manager.py Outdated
Comment threadairflow/providers/yandex/__init__.py Outdated
Comment threadairflow/providers/yandex/hooks/yandex.py Outdated
@ImpressionableRaccoon
ImpressionableRaccoon marked this pull request as draft December 28, 2023 21:19
@ImpressionableRaccoon
ImpressionableRaccoon marked this pull request as ready for review January 10, 2024 18:01
@ImpressionableRaccoon
ImpressionableRaccoon marked this pull request as draft January 12, 2024 14:39

@PiatachockPiatachock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. Mostly nit-s, endpoint parameter is important tho.

Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
@ImpressionableRaccoon
ImpressionableRaccoonforce-pushed the add-lockbox-secrets-backend branch 2 times, most recently from aa31fb2 to b1ce06eCompareJanuary 17, 2024 13:14

@PiatachockPiatachock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Yandex

@ImpressionableRaccoon
ImpressionableRaccoon marked this pull request as ready for review January 17, 2024 14:12
Taragolis
Taragolis previously requested changes Jan 17, 2024

@TaragolisTaragolis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern about Connection ID into the Secrets Manager, see appropriate conversation

Comment threadairflow/providers/yandex/utils/user_agent.py Outdated
Comment threadairflow/providers/yandex/hooks/yandex.py Outdated
Comment threadairflow/providers/yandex/hooks/yandex.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/utils/defaults.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
Comment threadairflow/providers/yandex/secrets/secrets_manager.py Outdated
@ImpressionableRaccoon

Copy link
Copy Markdown
ContributorAuthor

I think it's ready to merge

@Taragolis
Taragolis merged commit 12ccb5f into apache:mainJan 25, 2024
@boring-cyborg

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ImpressionableRaccoon@potiuk@Taragolis@Piatachock