Skip to content

Deprecate AutoMLTrainModelOperator for Vision and Video - #36473

Merged
potiuk merged 1 commit into
apache:mainfrom
VladaZakharova:ml-vision-deprecate
Jan 17, 2024
Merged

Deprecate AutoMLTrainModelOperator for Vision and Video#36473
potiuk merged 1 commit into
apache:mainfrom
VladaZakharova:ml-vision-deprecate

Conversation

@VladaZakharova

@VladaZakharovaVladaZakharova commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Lee-W
Lee-W reviewed Dec 29, 2023
View reviewed changes
Comment threadtests/system/providers/google/cloud/automl/example_automl_video_intelligence_classification.py
Comment threadtests/system/providers/google/cloud/automl/example_automl_video_intelligence_tracking.py Outdated
@VladaZakharova
VladaZakharovaforce-pushed the ml-vision-deprecate branch 4 times, most recently from 587ad6c to 53d13fbCompareJanuary 9, 2024 07:53
Lee-W
Lee-W approved these changes Jan 11, 2024
View reviewed changes

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick, but other parts looks good to me

Comment threadtests/system/providers/google/cloud/automl/example_automl_nl_text_classification.py Outdated
@VladaZakharova

VladaZakharova commented Jan 16, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi!
Can you please check this PR? :)
The service will be removed at the end of the month, so will be great to deprecate it at least :) Thank you!

Lee-W
Lee-W approved these changes Jan 16, 2024
View reviewed changes

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just browsed through it again. LGTM

@Lee-W

Lee-W commented Jan 16, 2024

Copy link
Copy Markdown
Member

If the text part is deprecated as well, should we added it to PR title?

@VladaZakharova

VladaZakharova commented Jan 16, 2024

Copy link
Copy Markdown
ContributorAuthor

If the text part is deprecated as well, should we added it to PR title?

Text was deprecated in another PR, long time ago :)

@Lee-W

Lee-W commented Jan 17, 2024

Copy link
Copy Markdown
Member

If the text part is deprecated as well, should we added it to PR title?

Text was deprecated in another PR, long time ago :)

Ah, yes, you're right. Missed the deleted docstring. Thanks for the prompt reply :)

@VladaZakharova

VladaZakharova commented Jan 17, 2024

Copy link
Copy Markdown
ContributorAuthor

@eladkal
Hi! Can you please check the PR? Thanks! :)

@potiuk
potiuk merged commit 437d4e4 into apache:mainJan 17, 2024
@eladkaleladkal mentioned this pull request Jan 22, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@Lee-WLee-WLee-W approved these changes

Assignees

No one assigned

Labels

area:providersarea:system-testskind:documentationprovider:googleGoogle (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VladaZakharova@Lee-W@potiuk