Skip to content

add deferrable mode to RedshiftClusterSensor - #36550

Merged
vincbeck merged 6 commits into
apache:mainfrom
astronomer:add-deferrable-mode-to-RedshiftClusterSensor
Jan 8, 2024
Merged

add deferrable mode to RedshiftClusterSensor#36550
vincbeck merged 6 commits into
apache:mainfrom
astronomer:add-deferrable-mode-to-RedshiftClusterSensor

Conversation

@Lee-W

@Lee-WLee-W commented Jan 3, 2024

Copy link
Copy Markdown
Member

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Jan 3, 2024
@Lee-W
Lee-Wforce-pushed the add-deferrable-mode-to-RedshiftClusterSensor branch 3 times, most recently from 9ecfa4c to ba69e00CompareJanuary 3, 2024 10:56
@Lee-W
Lee-Wforce-pushed the add-deferrable-mode-to-RedshiftClusterSensor branch from ba69e00 to d71ec88CompareJanuary 4, 2024 00:42

@dirraodirrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I have given one minor comment.

Comment threadairflow/providers/amazon/aws/triggers/redshift_cluster.py Outdated
@Lee-W
Lee-Wforce-pushed the add-deferrable-mode-to-RedshiftClusterSensor branch from 96ce06a to 65c5e2aCompareJanuary 4, 2024 07:35

@dirraodirrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lee-W
Lee-W marked this pull request as ready for review January 5, 2024 00:17
Comment threadairflow/providers/amazon/aws/triggers/redshift_cluster.py Outdated
Comment threadairflow/providers/amazon/aws/sensors/redshift_cluster.py Outdated
Comment threadtests/providers/amazon/aws/triggers/test_redshift_cluster.py Outdated
@Lee-W
Lee-Wforce-pushed the add-deferrable-mode-to-RedshiftClusterSensor branch from 65c5e2a to 5e68e02CompareJanuary 6, 2024 03:23
@Lee-W
Lee-Wforce-pushed the add-deferrable-mode-to-RedshiftClusterSensor branch from 5e68e02 to 3a64c88CompareJanuary 8, 2024 09:57
@vincbeck
vincbeck merged commit 4d5e05b into apache:mainJan 8, 2024
@Lee-W
Lee-W deleted the add-deferrable-mode-to-RedshiftClusterSensor branch June 5, 2024 06:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providersprovider:amazonAWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Lee-W@dirrao@o-nikolas@vincbeck