Uh oh!
There was an error while loading. Please reload this page.
add use_regex argument for allowing S3KeySensor to check s3 keys with regular expression - #36578
Merged
Merged
Conversation
19 tasks
Lee-Wforce-pushed
the
add-use-regex-to-S3KeySensor
branch
2 times, most recently
from
January 4, 2024 09:52
796494b to
ef390d8Comparedirrao
requested changes
Jan 4, 2024
dirrao
left a comment
Contributor
There was a problem hiding this comment.
It would be great if we can add the test cases for the regex.
Lee-W
commented
Jan 4, 2024
MemberAuthor
Yep, will do. Thanks for suggestion 😄 |
Lee-Wforce-pushed
the
add-use-regex-to-S3KeySensor
branch
from
January 8, 2024 09:25
2bce5f0 to
76eb51aCompareLee-W
marked this pull request as ready for review
January 8, 2024 09:27
Lee-Wforce-pushed
the
add-use-regex-to-S3KeySensor
branch
2 times, most recently
from
January 8, 2024 10:06
b465528 to
c005bffComparevincbeck
reviewed
Jan 8, 2024
vincbeck
left a comment
Contributor
There was a problem hiding this comment.
Looks like a cool feature users might be interested in. I think it is worth mentioning it in docs?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Lee-Wforce-pushed
the
add-use-regex-to-S3KeySensor
branch
from
January 9, 2024 04:01
c005bff to
a459a42Comparedirrao
approved these changes
Jan 9, 2024
o-nikolas
approved these changes
Jan 9, 2024
vincbeck
reviewed
Jan 9, 2024
Uh oh!
There was an error while loading. Please reload this page.
vincbeck
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.