Uh oh!
There was an error while loading. Please reload this page.
[FEAT] adds repair run functionality for databricks - #36601
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
dirrao
left a comment
There was a problem hiding this comment.
Can you add the test cases for the new functionality?
gaurav7261
commented
Jan 5, 2024
sure @dirrao, adding them |
gaurav7261
commented
Jan 6, 2024
Hi @dirrao, added test cases to get latest repair id, I look for earlier test cases for method |
dirrao
left a comment
There was a problem hiding this comment.
LGTM.
I would request data bricks expert to review this.
eladkal
commented
Jan 7, 2024
cc @alexott |
Uh oh!
There was an error while loading. Please reload this page.
gaurav7261
commented
Jan 8, 2024
Hi @pankajastro , I got the issue, seems like I missed the comma in method definition |
gaurav7261
commented
Jan 9, 2024
Hi @pankajastro can you please review this |
gaurav7261
commented
Jan 9, 2024
Hi @dirrao , since repair run will work with |
gaurav7261
commented
Jan 9, 2024
Hi @dirrao can you please rereview |
gaurav7261
commented
Jan 10, 2024
hi @dirrao@pankajastro , can you please approve for CI check |
dirrao
commented
Jan 10, 2024
Go through the below to setup the breeze. |
gaurav7261
commented
Jan 10, 2024
Hi @dirrao , I think CI is pending |
Hi @dirrao , fixed static checks, can you please run CI |
potiuk
commented
Jan 10, 2024
Still some errors :( . I recommend installing pre-commit and running |
gaurav7261
commented
Jan 10, 2024
sure @potiuk , doing that thanks |
gaurav7261
commented
Jan 10, 2024
done @potiuk |
gaurav7261
commented
Jan 11, 2024
dirrao
commented
Jan 11, 2024
@gaurav7261 I don't have permissions to trigger it. Let us wait for others to review and approve it. |
gaurav7261
commented
Jan 11, 2024
fixing ci static cheque |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
gaurav7261
commented
Jan 11, 2024
Hi @Taragolis i have fixed X|Y to int | None and also fixed the change that you mentioned, thanks for that, can you reapprove |
pankajastro
commented
Jan 11, 2024
I have approved ci 🤞 |
gaurav7261
commented
Jan 11, 2024
@pankajastro should i remove log.warn to log.info ```Check if there are no deprecate log warn...........................................Failed
airflow/providers/databricks/operators/databricks.py:93: log.warn(``` |
gaurav7261
commented
Jan 11, 2024
now only this error is there? |
gaurav7261
commented
Jan 11, 2024
@pankajastro goti it replaced log.warn from log.warning |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
gaurav7261
commented
Jan 11, 2024
done @Taragolis , please trigger CI |
gaurav7261
commented
Jan 11, 2024
HI @pankajastro , can you trigger it, I have made changes as mentioned by @Taragolis |
gaurav7261
commented
Jan 11, 2024
Hi @Taragolis@pankajastro , comma miss was there |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
[FEAT] add repair run functionality in
DatabricksRunNowOperatorThis is useful in MULTI TASK mode, where operator will auto retry only failed tasks rather than relying on airflow retries that will create a new run
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.