Skip to content

add --no-transform-percent to flynt to avoid transform logging text to f-string which conflicts check-lazy-logging hook - #36677

Closed
Lee-W wants to merge 1 commit into
apache:mainfrom
astronomer:disable-flynt-transform-on-percent
Closed

add --no-transform-percent to flynt to avoid transform logging text to f-string which conflicts check-lazy-logging hook#36677
Lee-W wants to merge 1 commit into
apache:mainfrom
astronomer:disable-flynt-transform-on-percent

Conversation

@Lee-W

@Lee-WLee-W commented Jan 9, 2024

Copy link
Copy Markdown
Member

- repo: https://github.com/ikamensh/flynt
formats the logging text into f-string which conflicts
- id: check-lazy-logging
. This PR disable the string formation for percentage to avoid the behavior


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-WLee-W changed the title add --no-transform-percent to flynt to avoid transform loggging text to f-string which conflict check-lazy-logging hookadd --no-transform-percent to flynt to avoid transform loggging text to f-string which conflict check-lazy-loging hookJan 9, 2024
@Lee-WLee-W changed the title add --no-transform-percent to flynt to avoid transform loggging text to f-string which conflict check-lazy-loging hookadd --no-transform-percent to flynt to avoid transform logging text to f-string which conflict check-lazy-logging hookJan 9, 2024
@Lee-WLee-W changed the title add --no-transform-percent to flynt to avoid transform logging text to f-string which conflict check-lazy-logging hookadd --no-transform-percent to flynt to avoid transform logging text to f-string which conflicts check-lazy-logging hookJan 9, 2024
@Lee-W
Lee-Wforce-pushed the disable-flynt-transform-on-percent branch 3 times, most recently from fb0bc68 to 160cdacCompareJanuary 9, 2024 10:54
…form loggging text to f-string which conflict check-lazy-logging hook
@Lee-W
Lee-Wforce-pushed the disable-flynt-transform-on-percent branch from 160cdac to 2ded0fbCompareJanuary 9, 2024 14:32
@Lee-WLee-W closed this Jan 10, 2024
@Lee-W
Lee-W deleted the disable-flynt-transform-on-percent branch June 5, 2024 06:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Lee-W