Uh oh!
There was an error while loading. Please reload this page.
Fix successful Apache Druid task submissions reported as failed - #36813
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
potiuk
commented
Jan 16, 2024
Could you please add a unit test covering it? |
Uh oh!
There was an error while loading. Please reload this page.
listik
commented
Jan 17, 2024
Hey @potiuk, I thought this unit test was already covering the |
potiuk
commented
Jan 21, 2024
Apparently it does not test what it should then. If you make a change fixing a problem and there is no test that fails before and get fixed after the change, it means that the error case has not been tested. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
potiuk
commented
Jan 24, 2024
Thanks for adding the test! |
listik
commented
Jan 24, 2024
Thank you for the feedback and patience! |
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
* Accept 202 status code response * Fix status message * Addresses [comment](apache/airflow#36813 (comment)) * Make tests cover actual behaviour GitOrigin-RevId: 5c4364aafe57f089746a833d96a76c68c8869e20
Apache Druid returns status code
202 Approvedon successful MSQ requests, but the hook is only checking for a200status code.This means MSQ ingestions are reported as failed by default, despite being successfully executed by the Druid service.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.