Skip to content

Add deferrable implementation in HTTPSensor - #36904

Merged
phanikumv merged 28 commits into
apache:mainfrom
astronomer:add_deferrable_to_httpsensor
Jan 23, 2024
Merged

Add deferrable implementation in HTTPSensor#36904
phanikumv merged 28 commits into
apache:mainfrom
astronomer:add_deferrable_to_httpsensor

Conversation

@vatsrahul1001

@vatsrahul1001vatsrahul1001 commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

This PR address deferrable logic for HTTPSensor

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vatsrahul1001
vatsrahul1001 marked this pull request as draft January 19, 2024 14:46
@vatsrahul1001
vatsrahul1001force-pushed the add_deferrable_to_httpsensor branch from 273c92e to b4d6b10CompareJanuary 19, 2024 16:32
@vatsrahul1001
vatsrahul1001 marked this pull request as ready for review January 19, 2024 16:36
Lee-W
Lee-W reviewed Jan 20, 2024
View reviewed changes
Comment threadairflow/providers/http/sensors/http.py Outdated
Comment threadairflow/providers/http/sensors/http.py Outdated
Comment threadtests/providers/http/sensors/test_http.py Outdated
Comment threadtests/providers/http/sensors/test_http.py Outdated
phanikumv
phanikumv reviewed Jan 22, 2024
View reviewed changes

@phanikumvphanikumv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding docs?

Lee-W
Lee-W reviewed Jan 22, 2024
View reviewed changes
Comment threadtests/providers/http/sensors/test_http.py Outdated
Comment threadtests/providers/http/sensors/test_http.py Outdated
Comment threadtests/providers/http/sensors/test_http.py Outdated
Comment threadtests/providers/http/sensors/test_http.py Outdated
Comment threadtests/providers/http/sensors/test_http.py Outdated
@vatsrahul1001@Lee-W
Apply suggestions from code review
eaa51cf
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@vatsrahul1001vatsrahul1001 mentioned this pull request Jan 22, 2024
Closed
1 task
Lee-W
Lee-W reviewed Jan 22, 2024
View reviewed changes
Comment threadtests/providers/http/sensors/test_http.py Outdated
@vatsrahul1001

vatsrahul1001 commented Jan 22, 2024

Copy link
Copy Markdown
ContributorAuthor

consider adding docs?

updated docs with example

Lee-W
Lee-W approved these changes Jan 23, 2024
View reviewed changes

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion but rest looks good to me

Comment threaddocs/apache-airflow-providers-http/operators.rst Outdated
Comment threadtests/system/providers/http/example_http.py Outdated
@phanikumv
phanikumv merged commit 9596bbd into apache:mainJan 23, 2024
@phanikumv
phanikumv deleted the add_deferrable_to_httpsensor branch January 23, 2024 06:18
@potiukpotiuk mentioned this pull request Jan 26, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-WLee-WLee-W approved these changes
@phanikumvphanikumvphanikumv approved these changes
@pankajastropankajastroAwaiting requested review from pankajastro
@pankajkotipankajkotiAwaiting requested review from pankajkoti

Assignees

No one assigned

Labels

area:providersprovider:http

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vatsrahul1001@Lee-W@phanikumv