Skip to content

Fix assignment of template field in __init__ in hive-stats - #36905

Merged
eladkal merged 2 commits into
apache:mainfrom
romsharon98:fix/hive-stats
Jan 19, 2024
Merged

Fix assignment of template field in __init__ in hive-stats#36905
eladkal merged 2 commits into
apache:mainfrom
romsharon98:fix/hive-stats

Conversation

@romsharon98

@romsharon98romsharon98 commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

related: #36484

fix:

HiveStatsCollectionOperator's constructor lacks direct assignments for instance members corresponding to the following template fields (i.e., self.field_name = field_name or super.__init__(field_name=field_name, ...) ):
['dttm', 'ds']
HiveStatsCollectionOperator's constructor contains invalid assignments to the following instance members that should be corresponding to template fields (i.e., self.field_name = field_name):
['self.ds', 'self.dttm']

cc: @shahar1


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Comment threadairflow/providers/apache/hive/operators/hive_stats.py Outdated
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
@eladkal
eladkal merged commit 1119b06 into apache:mainJan 19, 2024
@romsharon98
romsharon98 deleted the fix/hive-stats branch January 19, 2024 19:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@romsharon98@Taragolis@dirrao@eladkal