Skip to content

Add migration for rendered_map_index column in task_instance table. - #37708

Merged
uranusjr merged 3 commits into
apache:mainfrom
tirkarthi:add-migration
Feb 29, 2024
Merged

Add migration for rendered_map_index column in task_instance table.#37708
uranusjr merged 3 commits into
apache:mainfrom
tirkarthi:add-migration

Conversation

@tirkarthi

@tirkarthitirkarthi commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

Add migration for rendered_map_index column added to task_instance table in PR #36797

related: #36797

@tirkarthitirkarthi mentioned this pull request Feb 26, 2024
Merged
uranusjr
uranusjr reviewed Feb 26, 2024
View reviewed changes
Comment threadairflow/migrations/versions/0134_2_9_0_add_rendered_map_index_to_taskinstance.py Outdated
@jedcunningham

jedcunningham commented Feb 27, 2024

Copy link
Copy Markdown
Member

Didn't we have a test to ensure migrations and models always build the same db? Wonder when that broke...

@potiuk

potiuk commented Feb 27, 2024

Copy link
Copy Markdown
Member

Didn't we have a test to ensure migrations and models always build the same db? Wonder when that broke...

We never had those. We have a migration test that runs the migration up and down - but we never compared if the result is the same as the Models we have.

@potiuk

potiuk commented Feb 27, 2024

Copy link
Copy Markdown
Member

Just a watch-out - we have two migrations in-progress. I think we have a protection that will make the secon one not mergable if the first is but there will be some re-work needed once the other mighration is merged. #37731

@potiukpotiuk mentioned this pull request Feb 27, 2024
Merged
@uranusjr

uranusjr commented Feb 29, 2024

Copy link
Copy Markdown
Member

It’s interesting to me this does not show up in tests that use rendered_map_index though. SQLAlchemy is more permissive than I imagined…

@uranusjr
uranusjr merged commit 855a354 into apache:mainFeb 29, 2024
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 6, 2024
@ephraimbuddyephraimbuddy added this to the Airflow 2.9.0 milestone Mar 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamjedcunningham approved these changes

Assignees

No one assigned

Labels

changelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)kind:documentation

Projects

None yet

Milestone

Airflow 2.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tirkarthi@jedcunningham@potiuk@uranusjr@ephraimbuddy