Skip to content

Add a migration script for encrypted trigger kwargs - #38358

Merged
hussein-awala merged 9 commits into
apache:mainfrom
hussein-awala:38233/follow_up
Apr 1, 2024
Merged

Add a migration script for encrypted trigger kwargs#38358
hussein-awala merged 9 commits into
apache:mainfrom
hussein-awala:38233/follow_up

Conversation

@hussein-awala

@hussein-awalahussein-awala commented Mar 21, 2024

Copy link
Copy Markdown
Member

related: #38233

To avoid breaking the execution of created triggers after the upgrade to 2.9.0, we need to encrypt the kwargs during the migration process and decrypt them on downgrading to an older version.

@hussein-awala
hussein-awala marked this pull request as draft March 21, 2024 01:20
@hussein-awala

hussein-awala commented Mar 21, 2024

Copy link
Copy Markdown
MemberAuthor

Need to test it before marking it as ready for review.

@hussein-awalahussein-awala added this to the Airflow 2.9.0 milestone Mar 22, 2024
ephraimbuddy
ephraimbuddy reviewed Mar 25, 2024
View reviewed changes
Comment threadairflow/migrations/versions/0138_2_9_0_encrypt_trigger_kwargs.py Outdated
@feluellefeluelle added area:db-migrations PRs with DB migration and removed area:db-migrations PRs with DB migration labels Mar 28, 2024
utkarsharma2
utkarsharma2 reviewed Mar 28, 2024
View reviewed changes
Comment threadairflow/migrations/versions/0138_2_9_0_encrypt_trigger_kwargs.py Outdated
utkarsharma2
utkarsharma2 reviewed Mar 28, 2024
View reviewed changes
Comment threadairflow/migrations/versions/0138_2_9_0_encrypt_trigger_kwargs.py Outdated
hussein-awalaand others added 2 commits March 28, 2024 23:02
@hussein-awala@utkarsharma2
Apply suggestions from code review
95df482
Co-authored-by: Utkarsh Sharma <utkarsharma2@gmail.com>
@hussein-awala
Merge branch 'main' into 38233/follow_up
dd50211
@hussein-awalahussein-awala mentioned this pull request Mar 30, 2024
Merged
ephraimbuddy
ephraimbuddy reviewed Mar 31, 2024
View reviewed changes
Comment threadairflow/migrations/versions/0140_2_9_0_encrypt_trigger_kwargs.py Outdated
@hussein-awala
hussein-awala marked this pull request as ready for review March 31, 2024 21:59
@hussein-awalahussein-awala mentioned this pull request Mar 31, 2024
Merged
ephraimbuddy
ephraimbuddy reviewed Mar 31, 2024
View reviewed changes
Comment threadairflow/migrations/versions/0140_2_9_0_update_trigger_kwargs_type.py Outdated
ephraimbuddy
ephraimbuddy reviewed Apr 1, 2024
View reviewed changes
Comment threadairflow/migrations/versions/0140_2_9_0_update_trigger_kwargs_type.py Outdated
Comment threadairflow/migrations/versions/0140_2_9_0_update_trigger_kwargs_type.py Outdated
Comment threadairflow/migrations/versions/0140_2_9_0_update_trigger_kwargs_type.py Outdated
@hussein-awala
hussein-awala merged commit 6f0e5bc into apache:mainApr 1, 2024
@ephraimbuddyephraimbuddy added the type:improvement Changelog: Improvements label Apr 1, 2024
ephraimbuddy pushed a commit that referenced this pull request Apr 2, 2024
@hussein-awala@ephraimbuddy
Add a migration script for encrypted trigger kwargs (#38358)
c108064
(cherry picked from commit 6f0e5bc)
ephraimbuddy pushed a commit that referenced this pull request Apr 2, 2024
@hussein-awala@ephraimbuddy
Add a migration script for encrypted trigger kwargs (#38358)
4467cd6
(cherry picked from commit 6f0e5bc)
mathiaHT pushed a commit to mathiaHT/airflow that referenced this pull request Apr 4, 2024
@hussein-awalaMathia Haure-Touze
Add a migration script for encrypted trigger kwargs (apache#38358)
7a38e8e
@romanzdkromanzdk mentioned this pull request Apr 9, 2024
Closed
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ephraimbuddyephraimbuddyephraimbuddy approved these changes
@eladkaleladkaleladkal approved these changes
@potiukpotiukAwaiting requested review from potiuk
@ashbashbAwaiting requested review from ashb
@utkarsharma2utkarsharma2Awaiting requested review from utkarsharma2

Assignees

No one assigned

Labels

area:db-migrationsPRs with DB migrationkind:documentationtype:improvementChangelog: Improvements

Projects

None yet

Milestone

Airflow 2.9.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hussein-awala@ashb@ephraimbuddy@utkarsharma2@eladkal@feluelle