Skip to content

Delete deprecated AutoML operators (inc. 'google-cloud-automl' dep.) and deprecate hook and links - #38418

Merged
potiuk merged 1 commit into
apache:mainfrom
shahar1:delete-deprecated-automl-operators
Mar 24, 2024
Merged

Delete deprecated AutoML operators (inc. 'google-cloud-automl' dep.) and deprecate hook and links#38418
potiuk merged 1 commit into
apache:mainfrom
shahar1:delete-deprecated-automl-operators

Conversation

@shahar1

@shahar1shahar1 commented Mar 22, 2024

Copy link
Copy Markdown
Contributor

Starting March 31, 2024, GCP will sunset the old AutoML API, effectively making the deprecated operators, 'google-cloud-automl' dependency, links and hook unusable. This PR:

  • Removes the AutoML operators (+related tests/docs)
  • Removes the dependency 'google-cloud-automl'
  • Deprecates CloudAutoMLHook
  • Deprecates AutoML links.

The hook and the links haven't been formally deprecated in Airflow, so it might be better to take a bit more cautious approach before removing both, as theoretically someone could import them into their codebase without knowing that they are deprecated.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Mar 22, 2024
@shahar1
shahar1 marked this pull request as draft March 23, 2024 06:26
@shahar1
shahar1force-pushed the delete-deprecated-automl-operators branch from 141ed6d to ab920d2CompareMarch 23, 2024 08:02
@shahar1shahar1 changed the title Delete deprecated AutoML operators and hookDelete deprecated AutoML operators and deprecate CloudAutoMLHookMar 23, 2024
@shahar1
shahar1force-pushed the delete-deprecated-automl-operators branch from ab920d2 to 6af3a9aCompareMarch 23, 2024 08:22
@shahar1
shahar1 marked this pull request as ready for review March 23, 2024 08:23
@shahar1
shahar1 requested review from ashb and potiuk as code ownersMarch 23, 2024 08:23
@shahar1
shahar1force-pushed the delete-deprecated-automl-operators branch from 6af3a9a to cbc4a68CompareMarch 23, 2024 08:24
@shahar1
shahar1 marked this pull request as draft March 23, 2024 08:41
@shahar1shahar1 changed the title Delete deprecated AutoML operators and deprecate CloudAutoMLHookDelete deprecated AutoML operators and deprecate hook and linksMar 23, 2024
@shahar1
shahar1force-pushed the delete-deprecated-automl-operators branch from cbc4a68 to f2c54f2CompareMarch 23, 2024 08:59
@shahar1
shahar1 marked this pull request as ready for review March 23, 2024 08:59
Comment threadpyproject.toml Outdated
@shahar1
shahar1force-pushed the delete-deprecated-automl-operators branch 2 times, most recently from a19e1bf to 85c0f32CompareMarch 23, 2024 09:43
@shahar1shahar1 changed the title Delete deprecated AutoML operators and deprecate hook and linksDelete deprecated AutoML operators (inc. 'google-cloud-automl' dep.) and deprecate hook and linksMar 23, 2024
@shahar1
shahar1force-pushed the delete-deprecated-automl-operators branch from 85c0f32 to f167253CompareMarch 23, 2024 11:29
@shahar1
shahar1force-pushed the delete-deprecated-automl-operators branch from f167253 to 8c9d191CompareMarch 23, 2024 12:55
@potiuk
potiuk merged commit 4a4eee1 into apache:mainMar 24, 2024
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 25, 2024
@molcay

Copy link
Copy Markdown
Contributor

I will be reverting the commit

We want to take a bit of a different approach for depreciation since we did not include depreciation for most of the operators. Removing them without deprecation tends to become a breaking change and also mentioned here.
Also, we can still use most of the operators for AutoML Translate service

@shahar1

Copy link
Copy Markdown
ContributorAuthor

I will be reverting the commit

We want to take a bit of a different approach for depreciation since we did not include depreciation for most of the operators. Removing them without deprecation tends to become a breaking change and also mentioned here. Also, we can still use most of the operators for AutoML Translate service

Thanks for pointing it out!
I've been ahead of you and created #38633 to reverse this PR, but I am also working on a patch that will deprecate operators and hooks that become obsolete after GCP shuts AutoML for non-translation models. This deprecation will be "strong" (i.e., raising an error instead of a warning)- as they have no use in the AutoML Translation domain.

@shahar1
shahar1 deleted the delete-deprecated-automl-operators branch March 30, 2024 13:23
@molcay

Copy link
Copy Markdown
Contributor

Thank you for creating the revert PR @shahar1

Also, wrote to the PR #38633 and put a comment

This deprecation will be "strong" (i.e., raising an error instead of a warning)- as they have no use in the AutoML Translation domain.

Yes, indeed. I am already doing it. You can see my changes over this PR on another fork, I will be creating a community PR, ASAP (of course after the revert PR merged)

potiuk pushed a commit to shahar1/airflow that referenced this pull request Apr 2, 2024
potiuk pushed a commit that referenced this pull request Apr 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providersarea:system-testschangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)provider:googleGoogle (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shahar1@molcay@potiuk@ephraimbuddy