Skip to content

Brings back mypy-checks - #38597

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:bring-back-mypy-checks
Mar 28, 2024
Merged

Brings back mypy-checks#38597
potiuk merged 1 commit into
apache:mainfrom
potiuk:bring-back-mypy-checks

Conversation

@potiuk

Copy link
Copy Markdown
Member

During the last week refactor input on mypy checks was moved to another workflow and mypy checks were not running for a day.

This change brings it back.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
potiuk requested review from ashb and kaxil as code ownersMarch 28, 2024 22:02
@potiukpotiuk added the full tests needed We need to run full set of tests for this PR to merge label Mar 28, 2024
@potiuk
potiukforce-pushed the bring-back-mypy-checks branch 2 times, most recently from c2c1cd6 to dbcb0efCompareMarch 28, 2024 22:12
@potiuk

Copy link
Copy Markdown
MemberAuthor

It was literally day-and-a-half or so, so I hope there won't be many things to fix 😁

@potiuk

Copy link
Copy Markdown
MemberAuthor

Just one small issue :)

@potiukpotiuk added this to the Airflow 2.9.0 milestone Mar 28, 2024
During the last week refactor input on mypy checks was moved to
another workflow and mypy checks were not running for a day.
This change brings it back.
@potiuk
potiukforce-pushed the bring-back-mypy-checks branch from dbcb0ef to 00ccd31CompareMarch 28, 2024 22:40
@potiuk

Copy link
Copy Markdown
MemberAuthor

Should be fixed now.

@potiuk
potiuk merged commit a2f5307 into apache:mainMar 28, 2024
@potiuk
potiuk deleted the bring-back-mypy-checks branch March 28, 2024 23:08
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 31, 2024
ephraimbuddy pushed a commit that referenced this pull request Mar 31, 2024
During the last week refactor input on mypy checks was moved to
another workflow and mypy checks were not running for a day.
This change brings it back.
(cherry picked from commit a2f5307)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-toolschangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)full tests neededWe need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@potiuk@Taragolis@hussein-awala@ephraimbuddy