Uh oh!
There was an error while loading. Please reload this page.
Hide internals of some groupped workflows - #38604
Merged
Merged
Conversation
potiuk
requested review from
Taragolis, aritra24, eladkal, ephraimbuddy, hussein-awala and pankajkotiMarch 29, 2024 01:16
potiukforce-pushed
the
hide-internals-of-skipped-workflows
branch
from
March 29, 2024 01:18
99a5d62 to
2ce698fComparepotiuk
commented
Mar 29, 2024
MemberAuthor
Avoids this:  |
potiukforce-pushed
the
hide-internals-of-skipped-workflows
branch
2 times, most recently
from
March 29, 2024 01:37
00c3bf2 to
69cc522Comparepotiuk
commented
Mar 29, 2024
MemberAuthor
Reopened to check with upgrade-to-newer-dependencies. |
potiukforce-pushed
the
hide-internals-of-skipped-workflows
branch
2 times, most recently
from
March 29, 2024 13:23
4a01cd9 to
04567feComparepotiuk
commented
Mar 29, 2024
MemberAuthor
Should be good to go - seems to pass all the variants |
aritra24
approved these changes
Mar 29, 2024
aritra24
left a comment
Collaborator
There was a problem hiding this comment.
Had a question, but overall looks good
Uh oh!
There was an error while loading. Please reload this page.
potiukforce-pushed
the
hide-internals-of-skipped-workflows
branch
3 times, most recently
from
March 29, 2024 13:53
61ec66d to
7187a29CompareWhen the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests.
potiukforce-pushed
the
hide-internals-of-skipped-workflows
branch
from
March 29, 2024 13:53
7187a29 to
d9ba732Comparejscheffl
approved these changes
Mar 29, 2024
potiuk
commented
Mar 29, 2024
MemberAuthor
Merging. the "No pydantic" tests in main will be handled separately (need to skip some more tests in NoPydantic case). |
ephraimbuddy pushed a commit
that referenced
this pull request
Apr 16, 2024
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests. (cherry picked from commit 3f4872b)
ephraimbuddy pushed a commit
that referenced
this pull request
Apr 16, 2024
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests. (cherry picked from commit 3f4872b)
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow.
This is what we do for Additional CI image tests and Finalize tests & Special tests
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.