Uh oh!
There was an error while loading. Please reload this page.
Fix total_entries count on the event logs endpoint - #38625
Merged
Conversation
The `total_entries` count should reflect how many log entries match the filters provided, not simply how many rows are in the table total.
jedcunningham
requested review from
ephraimbuddy and pierrejeambrun
as code ownersMarch 29, 2024 19:35
potiuk
approved these changes
Mar 29, 2024
potiuk
commented
Mar 29, 2024
Member
nice catch |
eladkal
approved these changes
Mar 30, 2024
ephraimbuddy pushed a commit
that referenced
this pull request
Mar 31, 2024
The `total_entries` count should reflect how many log entries match the filters provided, not simply how many rows are in the table total. (cherry picked from commit 90e7b3f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
total_entriescount should reflect how many log entries match the filters provided, not simply how many rows are in the table total.I took the opportunity to do a little cleanup at the same time.