Uh oh!
There was an error while loading. Please reload this page.
Amazon Bedrock - Model Customization Jobs - #38693
Conversation
ferruzzi
commented
Apr 3, 2024
I also didn't add a BedrockDeleteCustomModelOperator because it is literally just a hook call: |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
syedahsn
left a comment
There was a problem hiding this comment.
LGTM. Nice work, I love all the optimizations we've made with supporting deferrable operators (AwsBaseWaiterTrigger, custom waiters, consistent structures etc.) Really simplifies the whole process 😄
Uh oh!
There was an error while loading. Please reload this page.
ferruzzi
commented
Apr 5, 2024
@o-nikolas@Taragolis@syedahsn - I refactored how we handle a name conflict. Can you please have another look and re-approve (or comment) when you get time? |
o-nikolas
commented
Apr 5, 2024
The code looks functionally correct to me. Although the |
ferruzzi
commented
Apr 5, 2024
@o-nikolas Reworked the |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Adds support for Model Customization Jobs. Includes changes to the hook(s), new Operator, Sensor, Trigger, Waiter, unit tests for the above, updates to the doc page, and additions to the system test.
Manually tested in Breeze using (wait_for_completion=False with a Sensor), wait_for_completion=True, and deferrable=True. Don't mind the first two, bugs were squashed , as seen in the rest of the runs :P
