') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Unify lazy db sequence implementations by uranusjr · Pull Request #39426 · apache/airflow · GitHub
Skip to content

Unify lazy db sequence implementations - #39426

Merged
uranusjr merged 3 commits into
apache:mainfrom
astronomer:refactor-sequence-db-interface
May 8, 2024
Merged

Unify lazy db sequence implementations#39426
uranusjr merged 3 commits into
apache:mainfrom
astronomer:refactor-sequence-db-interface

Conversation

@uranusjr

@uranusjruranusjr commented May 6, 2024

Copy link
Copy Markdown
Member

LazyXComAccessor and InletEventsAccessor are somewhat similar in purpose. A new LazySelectSequence is introduced with a more generic implementation that fits both use cases. This also implements the Sequence protocol a bit more efficiently in some places.

See #39367 for some context.

@uranusjr
uranusjrforce-pushed the refactor-sequence-db-interface branch 2 times, most recently from 2574c3c to 6c72107CompareMay 6, 2024 10:57
uranusjr
uranusjr commented May 6, 2024
View reviewed changes
Comment threadairflow/models/base.py Outdated
Comment threadairflow/models/xcom.py Outdated
@uranusjr
uranusjr marked this pull request as ready for review May 6, 2024 12:04
Lee-W
Lee-W reviewed May 7, 2024
View reviewed changes
Comment threadairflow/utils/db.py Outdated
@uranusjr
uranusjrforce-pushed the refactor-sequence-db-interface branch 3 times, most recently from 781ef71 to b0e6eafCompareMay 7, 2024 18:57
Lee-W
Lee-W reviewed May 8, 2024
View reviewed changes
Comment threadairflow/utils/db.py Outdated
Comment threadairflow/utils/db.py Outdated
Lee-W
Lee-W approved these changes May 8, 2024
View reviewed changes

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After second thought, these are just non-blocking nitpicks. I'm good with merging this one

ephraimbuddy
ephraimbuddy reviewed May 8, 2024
View reviewed changes
Comment threaddocs/apache-airflow/authoring-and-scheduling/dynamic-task-mapping.rst Outdated
@uranusjr
uranusjrforce-pushed the refactor-sequence-db-interface branch from 68c00fa to 502bdadCompareMay 8, 2024 10:52
uranusjr added 3 commits May 8, 2024 18:52
@uranusjr
Unify lazy db sequence implementations
6155608
LazyXComAccessor and InletEventsAccessor are somewhat similar in
purpose. A new LazySelectSequence is introduced with a more generic
implementation that fits both use cases. This also implements the
Sequence protocol a bit more efficiently in some places.
@uranusjr
Better function name
ce246df
@uranusjr
Same format for str and repr
3ee6f7c
@uranusjr
uranusjrforce-pushed the refactor-sequence-db-interface branch from 502bdad to 3ee6f7cCompareMay 8, 2024 10:53
@uranusjr
uranusjr merged commit a46a732 into apache:mainMay 8, 2024
@uranusjr
uranusjr deleted the refactor-sequence-db-interface branch May 8, 2024 11:28
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
@uranusjr@pateash
Unify lazy db sequence implementations (apache#39426)
f86a46d
@utkarsharma2utkarsharma2 added this to the Airflow 2.10.0 milestone Jun 3, 2024
@utkarsharma2utkarsharma2 added the type:improvement Changelog: Improvements label Jun 3, 2024
@johncmerfeldjohncmerfeld mentioned this pull request Nov 13, 2024
Closed
2 tasks
@johncmerfeldjohncmerfeld mentioned this pull request Dec 4, 2024
Closed
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-WLee-WLee-W approved these changes
@ephraimbuddyephraimbuddyephraimbuddy approved these changes
@eladkaleladkaleladkal approved these changes
@phanikumvphanikumvphanikumv approved these changes
@potiukpotiukAwaiting requested review from potiuk
@kaxilkaxilAwaiting requested review from kaxil
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@ashbashbAwaiting requested review from ashb
+1 more reviewer
@sunank200sunank200sunank200 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:coretype:improvementChangelog: Improvements

Projects

None yet

Milestone

Airflow 2.10.0

Development

Successfully merging this pull request may close these issues.

7 participants

@uranusjr@ephraimbuddy@Lee-W@sunank200@eladkal@phanikumv@utkarsharma2