') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Implement slicing in lazy sequence by uranusjr · Pull Request #39483 · apache/airflow · GitHub
Skip to content

Implement slicing in lazy sequence - #39483

Merged
uranusjr merged 3 commits into
apache:mainfrom
astronomer:lazy-sequence-slice
May 9, 2024
Merged

Implement slicing in lazy sequence#39483
uranusjr merged 3 commits into
apache:mainfrom
astronomer:lazy-sequence-slice

Conversation

@uranusjr

@uranusjruranusjr commented May 8, 2024

Copy link
Copy Markdown
Member

As promised in #39367.

We could arguably do this even lazier and resolve only when the items are iterated through (or accessed by index), but it seems to me if someone wants a slice of objects, they are likely to want to read at least the majority of them anyway, so it should be fine to just resolve the fetch eagerly into a list. Merging slice objects is a total pain I don't want to go through anyway.

Documentation is also added for DatasetEvent sequences to reflect the addition.

@uranusjr
uranusjr requested a review from potiuk as a code ownerMay 8, 2024 11:29
@uranusjr
uranusjrforce-pushed the lazy-sequence-slice branch from 603af62 to aac3422CompareMay 8, 2024 11:30
@uranusjr
Implement slicing in lazy sequence
5bb3fba
We *could* arguably do this even lazier and resolve only when the items
are iterated through (or accessed by index), but it seems to me if
someone wants a slice of objects, they are likely to want to read at
least the majority of them anyway, so it should be fine to just resolve
the fetch eagerly into a list. Merging slice objects is a total pain I
don't want to go through anyway.
Documentation is also added for DatasetEvent sequences to reflect the
addition.
@uranusjr
uranusjrforce-pushed the lazy-sequence-slice branch from aac3422 to 5bb3fbaCompareMay 8, 2024 12:29
@eladkaleladkal added this to the Airflow 2.10.0 milestone May 8, 2024
potiuk
potiuk reviewed May 8, 2024
View reviewed changes
Comment threadairflow/utils/db.py Outdated
potiuk
potiuk approved these changes May 8, 2024
View reviewed changes

@potiukpotiuk left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks. Good. The logic is a bit complex when start is negative (but yeah - optimization) - but I run a few more cases and it looks solid.

NIT - maybe worth to parameterize the test ? Not really necessary but maybe nicer in case we add some more complex silcing in the future?

@uranusjr
uranusjr merged commit f36f9f4 into apache:mainMay 9, 2024
@uranusjr
uranusjr deleted the lazy-sequence-slice branch May 9, 2024 02:44
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
@uranusjr@pateash
Implement slicing in lazy sequence (apache#39483)
c7db2ce
@utkarsharma2utkarsharma2 added the type:improvement Changelog: Improvements label Jun 3, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@uranusjr@romsharon98
Implement slicing in lazy sequence (apache#39483)
09801b7
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@eladkaleladkaleladkal approved these changes

Assignees

No one assigned

Labels

kind:documentationtype:improvementChangelog: Improvements

Projects

None yet

Milestone

Airflow 2.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@uranusjr@potiuk@eladkal@utkarsharma2