Uh oh!
There was an error while loading. Please reload this page.
[OPENLINEAGE] Introduce AirflowJobFacet and AirflowStateRunFacet - #39520
Conversation
Uh oh!
There was an error while loading. Please reload this page.
35778b2 to
ea6a570Compare3d6af0d to
7c0e499CompareUh oh!
There was an error while loading. Please reload this page.
77020dd to
ec4bc16Comparekacpermuda
commented
May 22, 2024
I had to add some words to spelling wordlist, due to the docs error in CI here. Let me know if there is a better solution to that problem, but part of these words have already been present, just with different capitalization. |
Uh oh!
There was an error while loading. Please reload this page.
kacpermuda
commented
May 23, 2024
I also added json specs for the facets, in a new directory. I was not sure if i should add the |
c415d62 to
773637aCompareUh oh!
There was an error while loading. Please reload this page.
kacpermuda
commented
Jun 3, 2024
Yes. When you run tests in PR "selective" checks are run, but when you run them in main "all" tests are run. In this case, there is an inconsistenty between what is excluded and what is included. On one hand selective checks want to run Look at the command executed: From selective checks: From compatibility check we have Apparently pytest overrides the ignore when we explicitly have |
This is the command that will be used after #40037 is merged and you rebase your PR (tests/providers/common/io is gone as explicit pytest parameter): |
potiuk
commented
Jun 4, 2024
Rebased after merging #40037 to see if it helps. |
potiuk
commented
Jun 4, 2024
OK. The original problem is fixed. Now the remaining problem is to add compatibility so that the openlineage tests can be run on Airflow 2.7 as well (following the different cases of how to handle compatibility described in the unit_tests.rst). |
0546e39 to
63d051aCompareSigned-off-by: Kacper Muda <mudakacper@gmail.com>
kacpermuda
commented
Jun 5, 2024
I fixed all the compatibility tests and adjusted the code itself so it works on all Airflow 2.7+ versions now without any issues. Imho it's ready to be merged |
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
closes: #39467
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.