Uh oh!
There was an error while loading. Please reload this page.
openlineage: migrate OpenLineage provider to V2 facets. - #39530
Conversation
2e86fb5 to
9947104Compare9947104 to
fc72488Compare0479252 to
e43e266CompareJDarDagran
commented
May 21, 2024
I ran |
e43e266 to
74bc580Comparepotiuk
commented
May 22, 2024
#39747 should fix the docker test in "Latest Botocore". |
74bc580 to
feaa46cComparemobuchowski
commented
May 22, 2024
@JDarDagran we probably need to bump cross-provider version dependencies. If someone has older OL provider version, and bumps some of the other provider versions, the openlineage methods will fail. |
potiuk
commented
May 22, 2024
As discussed with @mobuchowski -> we need to add back-compatibility |
feaa46c to
366b3edCompareI've added imports with weird-looking structure at first glance: ifTYPE_CHECKING:
# v2 importselse:
try:
# v2 importsexceptImportError:
# v1 importsThis satisfies mypy and works with previous OL provider versions. |
366b3ed to
be583acComparepotiuk
commented
Jun 8, 2024
Should we re-start discussion about common provider for that one? I have an idea.. |
3d9a6af to
5ca57f8CompareUh oh!
There was an error while loading. Please reload this page.
d128fb6 to
7233d74Compare
kacpermuda
left a comment
There was a problem hiding this comment.
That's a huge amount of work done, thanks @JDarDagran 🚀 I left some nit comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7233d74 to
2f876b6Compare2f876b6 to
5383a9cCompared92a54c to
0cb2346CompareJDarDagran
commented
Jul 23, 2024
@potiuk looks like I'm on green path finally consistently 🟢 Would love to get this merged soon as new features arrive and I still need to rebase and apply new imports :) |
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
0cb2346 to
1bfad60Compare
In OpenLineage/OpenLineage#2520 released in
openlineage-python==1.13.1there were introduced V2 classes for facets and events.