Skip to content

openlineage: migrate OpenLineage provider to V2 facets. - #39530

Merged
mobuchowski merged 7 commits into
apache:mainfrom
JDarDagran:openlineage/migrate-to-v2-facets
Jul 23, 2024
Merged

openlineage: migrate OpenLineage provider to V2 facets.#39530
mobuchowski merged 7 commits into
apache:mainfrom
JDarDagran:openlineage/migrate-to-v2-facets

Conversation

@JDarDagran

@JDarDagranJDarDagran commented May 9, 2024

Copy link
Copy Markdown
Contributor

In OpenLineage/OpenLineage#2520 released in openlineage-python==1.13.1 there were introduced V2 classes for facets and events.

@JDarDagran
JDarDagran marked this pull request as draft May 9, 2024 19:13
@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch 5 times, most recently from 2e86fb5 to 9947104CompareMay 15, 2024 19:08
@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch from 9947104 to fc72488CompareMay 21, 2024 10:30
@JDarDagran
JDarDagran marked this pull request as ready for review May 21, 2024 10:31
@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch 3 times, most recently from 0479252 to e43e266CompareMay 21, 2024 20:44
@JDarDagran

Copy link
Copy Markdown
ContributorAuthor

I ran breeze testing tests --upgrade-boto tests/providers/docker in main branch with latest CI image - getting same error results.
Celery integration test seems flaky, no?

@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch from e43e266 to 74bc580CompareMay 21, 2024 21:32
@potiuk

Copy link
Copy Markdown
Member

I ran breeze testing tests --upgrade-boto tests/providers/docker in main branch with latest CI image - getting same error results.

#39747 should fix the docker test in "Latest Botocore".

@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch from 74bc580 to feaa46cCompareMay 22, 2024 13:39
@mobuchowski

Copy link
Copy Markdown
Contributor

@JDarDagran we probably need to bump cross-provider version dependencies. If someone has older OL provider version, and bumps some of the other provider versions, the openlineage methods will fail.

@potiuk

Copy link
Copy Markdown
Member

As discussed with @mobuchowski -> we need to add back-compatibility try/import to past versions of the openlineage provider. We could even potentially add back-compatibility test suite for older version of of openlineage client < 1.13 to test it (symiliar to what we have in Pydantic/Botocore cases.

@JDarDagran

JDarDagran commented Jun 3, 2024

Copy link
Copy Markdown
ContributorAuthor

I've added imports with weird-looking structure at first glance:

ifTYPE_CHECKING:
# v2 importselse:
try:
# v2 importsexceptImportError:
# v1 imports

This satisfies mypy and works with previous OL provider versions.
I'll be adding backwards-compatibility cross-provider checks in separate PR soon.

@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch from 366b3ed to be583acCompareJune 4, 2024 10:25
@potiuk

Copy link
Copy Markdown
Member

Should we re-start discussion about common provider for that one? I have an idea..

@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch from 3d9a6af to 5ca57f8CompareJuly 19, 2024 07:55
Comment threadairflow/providers/amazon/provider.yaml Outdated
@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch 4 times, most recently from d128fb6 to 7233d74CompareJuly 22, 2024 06:19

@kacpermudakacpermuda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a huge amount of work done, thanks @JDarDagran 🚀 I left some nit comments

Comment threaddev/breeze/tests/test_packages.py Outdated
Comment threadtests/providers/dbt/cloud/utils/test_openlineage.py Outdated
Comment threadtests/providers/google/cloud/transfers/test_bigquery_to_gcs.py Outdated
Comment threadairflow/providers/openlineage/extractors/base.py Outdated
@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch from 7233d74 to 2f876b6CompareJuly 22, 2024 21:40
@JDarDagran
JDarDagran requested a review from potiukJuly 22, 2024 21:42
@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch from 2f876b6 to 5383a9cCompareJuly 22, 2024 22:02
@JDarDagran
JDarDagranforce-pushed the openlineage/migrate-to-v2-facets branch 2 times, most recently from d92a54c to 0cb2346CompareJuly 23, 2024 10:19
@JDarDagran

Copy link
Copy Markdown
ContributorAuthor

@potiuk looks like I'm on green path finally consistently 🟢 Would love to get this merged soon as new features arrive and I still need to rebase and apply new imports :)

Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@mobuchowski
mobuchowski merged commit 0206a4c into apache:mainJul 23, 2024
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providerschangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)provider:openlineageAIP-53

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@JDarDagran@potiuk@mobuchowski@dolfinus@eladkal@kacpermuda@ephraimbuddy