Skip to content

Add compatibility note for Listeners - #39544

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:add-compatibility-note-to-listeners
May 10, 2024
Merged

Add compatibility note for Listeners#39544
potiuk merged 1 commit into
apache:mainfrom
potiuk:add-compatibility-note-to-listeners

Conversation

@potiuk

Copy link
Copy Markdown
Member

While running tests for older versions of Airflow, it turned out that forward-compatibility is maintained for implemented interfaces but if someone implements listener using the latest version of listener, they will not be backwards-compatible with older versions of Airflow.

This PR adds a note about it to Airflow documentation.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk

potiuk commented May 10, 2024

Copy link
Copy Markdown
MemberAuthor

cc: @vandonr

@potiuk

Copy link
Copy Markdown
MemberAuthor

Follow-up after #38155 as result of running tests in #39513

@potiuk
potiuk requested a review from ephraimbuddyMay 10, 2024 12:47
@potiuk
potiukforce-pushed the add-compatibility-note-to-listeners branch from 268d54f to 553b21eCompareMay 10, 2024 12:49
Comment threaddocs/apache-airflow/administration-and-deployment/listeners.rst Outdated
@potiuk
potiukforce-pushed the add-compatibility-note-to-listeners branch from 553b21e to a138de2CompareMay 10, 2024 12:50
While running tests for older versions of Airflow, it turned out that
forward-compatibility is maintained for implemented interfaces but if
someone implements listener using the latest version of listener,
they will not be backwards-compatible with older versions of Airflow.
This PR adds a note about it to Airflow documentation.
@potiuk
potiukforce-pushed the add-compatibility-note-to-listeners branch from a138de2 to 0b1e729CompareMay 10, 2024 12:59

@mobuchowskimobuchowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this @potiuk. It's very helpful.

@potiuk
potiuk merged commit f219027 into apache:mainMay 10, 2024
@potiuk
potiuk deleted the add-compatibility-note-to-listeners branch May 10, 2024 13:17
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
While running tests for older versions of Airflow, it turned out that
forward-compatibility is maintained for implemented interfaces but if
someone implements listener using the latest version of listener,
they will not be backwards-compatible with older versions of Airflow.
This PR adds a note about it to Airflow documentation.
@utkarsharma2utkarsharma2 added the type:doc-only Changelog: Doc Only label Jun 3, 2024
@utkarsharma2utkarsharma2 added this to the Airflow 2.10.0 milestone Jun 3, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
While running tests for older versions of Airflow, it turned out that
forward-compatibility is maintained for implemented interfaces but if
someone implements listener using the latest version of listener,
they will not be backwards-compatible with older versions of Airflow.
This PR adds a note about it to Airflow documentation.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@potiuk@mobuchowski@utkarsharma2