Uh oh!
There was an error while loading. Please reload this page.
feat: Add custom provider runtime checks - #39609
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
a523888 to
6703817Comparepotiuk
commented
May 14, 2024
Also - we need to actually bump openlineage to 1.8.0 in provider.yaml to make the Provider tests pass (it failed now correctly detecting wrong version :D). |
6703817 to
ba58e63Comparekacpermuda
commented
May 14, 2024
I was wondering how to do it aside the release process not to break anything, as doing it by hand seemed really wrong to me . I modified the changelog, init and provider.yaml, is that the correct approach ? I want to make sure that for the next release it will not get bumped again, and in result the 1.8.0 will not exist. |
potiuk
commented
May 14, 2024
Yes. It's OK. But @eladkal needs to know it has been done. |
potiuk
commented
May 14, 2024
BTW. Both workflows aare fine. It's generally OK to bump minor version of package if we know change is breakin. The |
kacpermuda
commented
May 14, 2024
Also, where are we with Airflow 2.10 on timeline? Do you think there will be time for next providers release before the 2.10. release? We need to make sure that, by accident, we don't get the |
potiuk
commented
May 14, 2024
No worries, that will take quite some time (months rather than weeks). |
4c83d0a to
1ec4658CompareUh oh!
There was an error while loading. Please reload this page.
1ec4658 to
c3e910fComparekacpermuda
commented
May 14, 2024
potiuk
commented
May 14, 2024
@eladkal ? |
c712b77 to
20e22fbCompareSigned-off-by: Kacper Muda <mudakacper@gmail.com>
20e22fb to
2261773CompareI think we should also update |
eladkal
commented
May 22, 2024
constraints-main is updated automatically. sometimes it takes time for the job to be completed |
potiuk
commented
May 22, 2024
Seems that they have not been updated for a while, there were few main failures to prevent it but likely after #39747 we are likely to get them updated |
utkarsharma2
commented
May 22, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
As discussed here at pr #39513, changes introduced by #39336 make all previous OpenLineage provider versions incompatible with Airflow >= 2.10.0 (due to changes in try_number behaviour change in core Airflow).
Using previous version of provider is still possible for Airflow >= 2.10.0, but will cause invalid behaviour (yet it will not cause any errors). We can't modify already released versions and provide a max supported Airflow version so we'd like to have a runtime check to ensure that a compatible version of OL provider is installed
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.