Uh oh!
There was an error while loading. Please reload this page.
Add mssql integration tests and relocate existing unit tests - #39831
Conversation
Uh oh!
There was an error while loading. Please reload this page.
f83ab8f to
4e900b1Compare4e900b1 to
29e3701Comparemssql integration testsmssql integration tests and relocate existing unit testsUh oh!
There was an error while loading. Please reload this page.
potiuk
commented
May 26, 2024
Nice. - few nits and solving failing tests (I guess some rebase needed?) |
29e3701 to
c0ca8c5Comparepotiuk
commented
May 26, 2024
One more thing: you also need to add Mssql as individual integration to test in |
c0ca8c5 to
42d4c49CompareUh oh!
There was an error while loading. Please reload this page.
potiuk
commented
May 27, 2024
Nice! |
potiuk
commented
May 27, 2024
@eladkal@shahar1 I also added #39866 as follow-up -> I realized that the last step was not obvious (having to add integration test step to integration-tests.yml was quite a bit duplication - also recently the "self-hosted" "all-testable" integrations when all of the integrations are started together have been somewhat flaky (as opposed to individual integrations) - so the #39866 will simplify it: removes the duplication and always runs the integration tests individually on public runners for both mssql and postgres. |
closes: #38577
This PR:
mssqlfrom the integration directory back to the unit tests (see Restore providers' unit tests marked as integration tests #39768)mssql.mssqlhook.bigquery_to_mssql.pymssql_to_gcs.pymssql_to_hive.pycc: @potiuk, @Taragolis, @eladkal
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.