Uh oh!
There was an error while loading. Please reload this page.
local task job: add overtime mechanism, to not kill task prematurely when auxiliary processes are running - #39890
Merged
Merged
Conversation
mobuchowskiforce-pushed
the
listener-task-timeout
branch
from
May 30, 2024 12:57
460fadf to
32e46ddComparemobuchowski
marked this pull request as ready for review
May 30, 2024 13:01
Uh oh!
There was an error while loading. Please reload this page.
Closed
2 tasks
potiuk
reviewed
Jun 1, 2024
Uh oh!
There was an error while loading. Please reload this page.
mobuchowskiforce-pushed
the
listener-task-timeout
branch
2 times, most recently
from
June 4, 2024 16:52
430c4fa to
e2acd51Comparemobuchowskiforce-pushed
the
listener-task-timeout
branch
from
June 5, 2024 21:25
e2acd51 to
ec1b194Comparemobuchowskiforce-pushed
the
listener-task-timeout
branch
2 times, most recently
from
June 10, 2024 14:40
f0128ce to
3d4661dComparepotiuk
approved these changes
Jun 11, 2024
potiuk
commented
Jun 11, 2024
Member
Nice and simple. I think we should have another committer to take a look as well. |
jscheffl
approved these changes
Jun 11, 2024
Uh oh!
There was an error while loading. Please reload this page.
…tener prematurely Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowskiforce-pushed
the
listener-task-timeout
branch
from
June 12, 2024 14:53
3d4661d to
7b0404bCompare96 tasks
20 tasks
romsharon98 pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…tener prematurely (apache#39890) Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kaxil added a commit
that referenced
this pull request
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in #39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closes#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
got686-yandex pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 27, 2025
This PR ports the overtime feature on `LocalTaskJob` (added in apache/airflow#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache/airflow#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor. GitOrigin-RevId: d059d4a84b526e5f975d17c6846f5c8e29adbc3a
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2025
This PR ports the overtime feature on `LocalTaskJob` (added in apache/airflow#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache/airflow#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor. GitOrigin-RevId: d059d4a84b526e5f975d17c6846f5c8e29adbc3a
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 21, 2025
This PR ports the overtime feature on `LocalTaskJob` (added in apache/airflow#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache/airflow#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor. GitOrigin-RevId: d059d4a84b526e5f975d17c6846f5c8e29adbc3a
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 26, 2026
This PR ports the overtime feature on `LocalTaskJob` (added in apache/airflow#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache/airflow#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor. GitOrigin-RevId: d059d4a84b526e5f975d17c6846f5c8e29adbc3a
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 27, 2026
This PR ports the overtime feature on `LocalTaskJob` (added in apache/airflow#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache/airflow#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor. GitOrigin-RevId: d059d4a84b526e5f975d17c6846f5c8e29adbc3a
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 29, 2026
This PR ports the overtime feature on `LocalTaskJob` (added in apache/airflow#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache/airflow#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor. GitOrigin-RevId: d059d4a84b526e5f975d17c6846f5c8e29adbc3a
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 3, 2026
This PR ports the overtime feature on `LocalTaskJob` (added in apache/airflow#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closesapache/airflow#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor. GitOrigin-RevId: d059d4a84b526e5f975d17c6846f5c8e29adbc3a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
LocalTaskJobRunnerkills worker processes after they have their state set toSUCCESSand are still running. This can happen in few ways - most common are either state is set externally, or there are relatively slow listeners or other processes (mini scheduler) running.This PR introduces mechanism in which we give the task some additional to finish their job - by default 20 seconds, configurable - after which the process is terminated.