Uh oh!
There was an error while loading. Please reload this page.
Fix pre-mature evaluation of tasks in mapped task group - #40460
Merged
shahar1 merged 2 commits intoFeb 7, 2025
Conversation
shahar1force-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
3 times, most recently
from
July 13, 2024 11:40
2399576 to
a69699eCompareContributor
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
eladkalforce-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
August 31, 2024 07:21
a69699e to
708a89cCompareeladkalforce-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
October 4, 2024 01:56
708a89c to
2eba0aeCompareshahar1force-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
October 12, 2024 13:37
2eba0ae to
4d40d46Compareshahar1force-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
October 13, 2024 20:28
4d40d46 to
caf4087Compareeladkalforce-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
December 2, 2024 15:59
caf4087 to
9808276Compareshahar1force-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
December 14, 2024 06:29
9808276 to
9e1ea99Compare
This was referenced Dec 14, 2024
shahar1force-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
December 14, 2024 18:38
9e1ea99 to
33dee9cCompareshahar1
marked this pull request as ready for review
December 14, 2024 18:38
shahar1force-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
2 times, most recently
from
December 14, 2024 19:19
a2025d1 to
ae05cabCompareContributorAuthor
shahar1
marked this pull request as draft
December 14, 2024 20:10
kaxil
commented
Dec 16, 2024
Member
@amoghrajesh is planning to take that on in the next coming days |
shahar1force-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
February 1, 2025 13:12
ae05cab to
ab1294fCompareshahar1
marked this pull request as ready for review
February 1, 2025 13:13
40 tasks
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
shahar1force-pushed
the
fix-premature-evaluation-in-mapped-task-group
branch
from
February 7, 2025 10:00
ab1294f to
63f9fedCompareContributorAuthor
Not blocked anymore as mapped operators were handled in |
ashb
reviewed
Feb 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
eladkal
approved these changes
Feb 7, 2025
niklasr22 pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
* Fix pre-mature evaluation of tasks in mapped task group Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> * Update airflow/ti_deps/deps/trigger_rule_dep.py Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
ambika-garg pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* Fix pre-mature evaluation of tasks in mapped task group Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> * Update airflow/ti_deps/deps/trigger_rule_dep.py Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com> --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #34023
previous attempts: #34337 (and subsequent #36462 which has been stale and closed)
related issues: #35541
ports: #44937
This PR deals with handling pre-mature evaluation of tasks in mapped task group, which happens when using one of the "fast" trigger rules, and specifically
ONE_FAILED[1]. This PR adds the exact logic presented by @uranusjr and @ephraimbuddy in the previous attempt (#34337), with a slight modification to be executed only for the appropriate trigger rules (the previous attempt has been reverted due to a bug that it caused). The slight modification is rather adding a simpleifstatement, which seems to do the job.For a more robust and performent solution, I think that eventually we'll have to completely refactor the trigger rule dependencies (as their code is quite messy atm).
[1] Theoretically it might also happen in the other "fast" trigger rules (
ONE_SUCCESS,ONE_DONE), but I couldn't come up with good test case for that.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.