Skip to content

Deprecate implicit default DAG schedule - #41321

Merged
uranusjr merged 30 commits into
apache:mainfrom
astronomer:deprecate-missing-schedule
Aug 14, 2024
Merged

Deprecate implicit default DAG schedule#41321
uranusjr merged 30 commits into
apache:mainfrom
astronomer:deprecate-missing-schedule

Conversation

@uranusjr

@uranusjruranusjr commented Aug 7, 2024

Copy link
Copy Markdown
Member

Currently, if a DAG is created without the 'schedule' argument, Airflow sets the DAG to run daily. This is almost never what people want, and every best practice tells you to always specify the argument explicitly, but we couldn't change the default due to compatibility considerations.

We can finally change this in Airflow 3.0, but first we need to tell users about it.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Currently, if a DAG is created with the 'schedule' argument, Airflow
sets the DAG to run daily. This is almost never what people want, and
every best practice tells you to always specify the argument explicitly,
but we couldn't change the default due to compatibility considerations.
We can finally change this in Airflow 3.0, but first we need to tell
users about it.
@uranusjruranusjr added this to the Airflow 2.10.0 milestone Aug 7, 2024
Comment threadairflow/models/dag.py
@uranusjr
uranusjrforce-pushed the deprecate-missing-schedule branch from fe49f6c to 2de04c7CompareAugust 8, 2024 08:12
@uranusjr
uranusjrforce-pushed the deprecate-missing-schedule branch from 2f54b65 to d12b93dCompareAugust 14, 2024 01:33
@uranusjruranusjr changed the title Change default DAG schedule to NoneDeprecate implicit default DAG scheduleAug 14, 2024
@eladkal

Copy link
Copy Markdown
Contributor

A backport to the 2.10 branch is needed.

According to the new rules it's on the committer who merges it to backport it and create a new PR if I read them right.

I raised #41457 to document the protocols

@uranusjr
uranusjrforce-pushed the deprecate-missing-schedule branch from a72b193 to 210df42CompareAugust 14, 2024 09:10
@uranusjr

Copy link
Copy Markdown
MemberAuthor

Finally… now merge and work on bacporting.

@uranusjr
uranusjr merged commit 3f2cf33 into apache:mainAug 14, 2024
@uranusjr
uranusjr deleted the deprecate-missing-schedule branch August 14, 2024 10:50
@uranusjruranusjr removed this from the Airflow 2.10.0 milestone Aug 14, 2024
uranusjr added a commit to astronomer/airflow that referenced this pull request Aug 15, 2024
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@malthe

Copy link
Copy Markdown
Contributor

s/with/without a ‘schedule’ argument.

Artuz37 pushed a commit to Artuz37/airflow that referenced this pull request Aug 19, 2024
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Aug 20, 2024
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@utkarsharma2utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 30, 2024
@utkarsharma2utkarsharma2 added this to the Airflow 2.10.1 milestone Aug 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@uranusjr@kaxil@potiuk@eladkal@malthe@hussein-awala@jedcunningham@jscheffl@vincbeck@utkarsharma2