Uh oh!
There was an error while loading. Please reload this page.
Fix tests/models/test_taskinstance.py for Database Isolation Tests - #41344
Merged
jscheffl merged 1 commit intoAug 9, 2024
Merged
Conversation
jscheffl
requested review from
XD-DENG, ashb, bolkedebruin and kaxil
as code ownersAugust 8, 2024 23:07
bugraoz93
commented
Aug 9, 2024
Contributor
This is used from multiple sources in the tests. Thanks for the change! I think it will make it easy to fix the test using this method from conftest. |
vincbeck
approved these changes
Aug 9, 2024
jscheffl added a commit
to jscheffl/airflow
that referenced
this pull request
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #41067
Fixes the
tests/models/test_taskinstance.pyfor Database Isolation Tests.Small adjustments on conftest allowing to pass the serialization parameter also for task_instance only creations.
As I was reworking the tests, I needed to notice that the function
get_previous_start_date()was missing on the pydantic model - added in scope of this PR.FYI @bugraoz93