Uh oh!
There was an error while loading. Please reload this page.
fix DagPriorityParsingRequest unique constraint error when dataset aliases are resolved into new datasets - #41398
Merged
utkarsharma2 merged 3 commits intoAug 12, 2024
Conversation
Lee-Wforce-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
August 12, 2024 07:21
953a2a7 to
342bc09CompareLee-W
requested review from
XD-DENG, ashb, bbovenzi, bolkedebruin, dstandish, eladkal, ephraimbuddy, hussein-awala, jedcunningham, jhtimmins, kaxil, o-nikolas, pierrejeambrun, potiuk, ryanahamilton and uranusjr
as code ownersAugust 12, 2024 07:22
Lee-W
commented
Aug 12, 2024
MemberAuthor
will create another PR point to main once merged |
potiuk
commented
Aug 12, 2024
Member
FYI - this one has a lot more commits than intended I think |
Lee-W
commented
Aug 12, 2024
MemberAuthor
ah yes, I should rebase from |
Lee-Wforce-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
August 12, 2024 07:33
342bc09 to
de5e735CompareContributor
@Lee-W We should raise this PR against the main and once merged, we'll do a cherry-pick to |
Lee-W
commented
Aug 12, 2024
MemberAuthor
Got it. Thanks @utkarsharma2 ! let me change it |
Lee-Wforce-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
August 12, 2024 08:11
de5e735 to
ad2f621CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ephraimbuddy
approved these changes
Aug 12, 2024
Lee-Wforce-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
August 12, 2024 08:44
0c54643 to
c62728cCompareeladkal
approved these changes
Aug 12, 2024
…t error when dataset aliases are resolved into new datasets this happens when dynamic task mapping is used
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Lee-Wforce-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
August 12, 2024 08:53
c62728c to
82d86f0Compareutkarsharma2
approved these changes
Aug 12, 2024
utkarsharma2
deleted the
fix-dag-parsing-request-unique-constraint-error
branch
August 12, 2024 09:25
utkarsharma2 pushed a commit
that referenced
this pull request
Aug 12, 2024
…iases are resolved into new datasets (#41398) * fix(datasets/manager): fix DagPriorityParsingRequest unique constraint error when dataset aliases are resolved into new datasets this happens when dynamic task mapping is used * refactor(dataset/manager): reword debug log Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> * refactor(dataset/manager): remove unnecessary logging Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> --------- Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> (cherry picked from commit bf64cb6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This happens when dynamic task mapping is used as each task create the exact same
DagPriorityParsingRequests.What
Follow how dataset queue a DagRun. ignore the conflict trasctions
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.