Skip to content

Check breaking changes have a news fragment - #41443

Merged
uranusjr merged 2 commits into
apache:mainfrom
astronomer:require-news-fragment
Aug 14, 2024
Merged

Check breaking changes have a news fragment#41443
uranusjr merged 2 commits into
apache:mainfrom
astronomer:require-news-fragment

Conversation

@uranusjr

Copy link
Copy Markdown
Member

This adds a CI step for PRs with the label airflow3.0:breaking and ensure they include a news fragment.

@uranusjruranusjr added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 13, 2024
@uranusjr
uranusjrforce-pushed the require-news-fragment branch from 4b8f2b8 to 1c3429fCompareAugust 13, 2024 18:46
@uranusjr
uranusjrforce-pushed the require-news-fragment branch 2 times, most recently from 5a5e326 to d5ab960CompareAugust 13, 2024 18:54
@uranusjr
uranusjrforce-pushed the require-news-fragment branch 5 times, most recently from a09f36b to d7dd711CompareAugust 13, 2024 19:11
@uranusjruranusjr removed the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 13, 2024
@uranusjr
uranusjrforce-pushed the require-news-fragment branch from d7dd711 to 50e365eCompareAugust 13, 2024 19:12
@uranusjr
uranusjrforce-pushed the require-news-fragment branch from 50e365e to 0c86122CompareAugust 13, 2024 19:14
@uranusjruranusjr added airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes and removed airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes labels Aug 13, 2024
@uranusjr

Copy link
Copy Markdown
MemberAuthor

Finally figured this out; should be mergable after CI.

Comment thread.github/workflows/news-fragment.yml
Comment thread.github/workflows/news-fragment.yml Outdated
@uranusjruranusjr added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 13, 2024
@uranusjr
uranusjrforce-pushed the require-news-fragment branch 2 times, most recently from 896ee69 to baf85aeCompareAugust 13, 2024 22:51
@uranusjruranusjr removed the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 13, 2024
@uranusjr
uranusjrforce-pushed the require-news-fragment branch from baf85ae to 3d6109dCompareAugust 13, 2024 22:53
@uranusjr
uranusjr merged commit 509f15e into apache:mainAug 14, 2024
@uranusjr
uranusjr deleted the require-news-fragment branch August 14, 2024 01:45
@uranusjr

Copy link
Copy Markdown
MemberAuthor

I’m going to have this in main first and worry about improvements (might not be that much needed anyway) later.

@vincbeck

Copy link
Copy Markdown
Contributor

This test is failing in #41434 although there is one newsfragment

@uranusjr

Copy link
Copy Markdown
MemberAuthor

There’s Checks SKIPPED: news file changes detected. so a file was found, but the test still failed. I think we’re using the conditions wrong…

Artuz37 pushed a commit to Artuz37/airflow that referenced this pull request Aug 19, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Aug 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@uranusjr@vincbeck@potiuk@kaxil@jedcunningham