Uh oh!
There was an error while loading. Please reload this page.
Add support for semicolon stripping to DbApiHook, PrestoHook, and TrinoHook - #41916
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
commented
Sep 1, 2024
You will have to:
|
Illumaria
commented
Sep 3, 2024
Whoops... Sorry. 🙏🏻 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eladkal
commented
Sep 6, 2024
@Illumaria can you address the needed changes? I'm hoping to include this PR in the next release |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eladkal
commented
Sep 6, 2024
needs rebase and resolve conflicts |
Illumaria
commented
Sep 6, 2024
@eladkal Sure, I’ll do it by the end of the weekend. |
potiuk
commented
Nov 12, 2024
Rebased after merging #43913 |
The above test failures are due to using |
Uhm... Is this a network issue on GitHub side? O_o |
potiuk
commented
Nov 13, 2024
Yeah.... Happens |
We (committers) can re-start that one failed job later after this PR completes all other checks. |
Illumaria
commented
Nov 13, 2024
@potiuk Could you please re-run the failed test job? I don't think I have the rights. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
potiuk
commented
Nov 13, 2024
Wooooohooo! (CC: @eladkal ) |
potiuk
commented
Nov 13, 2024
Thanks @Illumaria for the patience. It was not an easy one and it uncovered a number of edge-cases in our CI that we had to fix :) #protm |
eladkal
commented
Nov 13, 2024
Great work @Illumaria 👏🏻👏🏻 |
…noHook (apache#41916) --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
…noHook (apache#41916) --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Closes: #34828