Uh oh!
There was an error while loading. Please reload this page.
fix(providers/common/sql): add dummy connection setter for backward compatibility - #42490
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e87f608 to
8b35d2bCompare
ashb
left a comment
There was a problem hiding this comment.
This stops the error, but why does it work? Were those providers never reading self.connection again?
They're reading through the newly introduced property |
ephraimbuddy
left a comment
There was a problem hiding this comment.
Can you patch this change on old common/sql and test with the affected mysql?
My understanding is that the connection would be read from 'get_conn' which validates this change but yeah, let's test with a patch
…compatibility the introduction of connection property breaks apache-airflow-providers-mysql<5.7.1, apache-airflow-providers-elasticsearch<5.5.1 and apache-airflow-providers-postgres<5.13.0
8b35d2b to
8e3ea21CompareDoes the dummy setter solve this issue now? The problem is caused by my PR 40751. |
Lee-W
commented
Sep 26, 2024
Yep, works as expected |
dabla
commented
Sep 26, 2024
Good to hear, sorry for the caused inconvenience. |
…ompatibility (apache#42490) the introduction of connection property breaks apache-airflow-providers-mysql<5.7.1, apache-airflow-providers-elasticsearch<5.5.1 and apache-airflow-providers-postgres<5.13.0
…ompatibility (apache#42490) the introduction of connection property breaks apache-airflow-providers-mysql<5.7.1, apache-airflow-providers-elasticsearch<5.5.1 and apache-airflow-providers-postgres<5.13.0
Why
The introduction of connection property breaks
apache-airflow-providers-mysql<5.7.1,apache-airflow-providers-elasticsearch<5.5.1andapache-airflow-providers-postgres<5.13.0What
Add a dummy connection setter
Closes: #42452
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.