Uh oh!
There was an error while loading. Please reload this page.
AIP-84 Migrate views /object/historical_metrics_data to Fast API - #42629
Merged
pierrejeambrun merged 15 commits intoOct 9, 2024
Conversation
bugraoz93
requested review from
bbovenzi, ephraimbuddy, jscheffl, pierrejeambrun and ryanahamilton
as code ownersOctober 1, 2024 19:37
bbovenzi
reviewed
Oct 2, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bbovenzi
commented
Oct 3, 2024
Contributor
One nit after looking at the autogenerated code. Let's drop the word |
bbovenzi
reviewed
Oct 3, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pierrejeambrun
approved these changes
Oct 7, 2024
pierrejeambrun
commented
Oct 7, 2024
Member
@bugraoz93 can you rebase the branch before I merge please, it is quite behind main. Thanks :) |
bugraoz93force-pushed
the
42623/aip-84/historical-metrics-data
branch
from
October 7, 2024 17:16
3d4fe0e to
2b6a3edComparebugraoz93
commented
Oct 7, 2024
ContributorAuthor
For sure, @pierrejeambrun, I rebased it. Thanks! :) |
bugraoz93
commented
Oct 7, 2024
ContributorAuthor
Okay, merges after my rebase caused conflicts. Solving them and rebasing again :) |
bugraoz93force-pushed
the
42623/aip-84/historical-metrics-data
branch
from
October 7, 2024 17:52
8d7cd63 to
bbcefb6Comparebbovenzi
commented
Oct 8, 2024
Contributor
Looks like we need another rebase and then running pre-commit for the auto-generated files. |
bugraoz93force-pushed
the
42623/aip-84/historical-metrics-data
branch
from
October 9, 2024 00:24
bbcefb6 to
4120809Compare…arameter in parameters.py
…rt response to HistoricalMetricDataResponse
…arameter in parameters.py
bugraoz93force-pushed
the
42623/aip-84/historical-metrics-data
branch
from
October 9, 2024 00:29
4120809 to
3de5f75Comparebugraoz93
commented
Oct 9, 2024
ContributorAuthor
Rebased and run the hooks. |
bugraoz93
commented
Oct 9, 2024
ContributorAuthor
While running the hooks, a new PR merged. I rebased again just in case. The speed of the development 🚀 :) |
pierrejeambrun
approved these changes
Oct 9, 2024
kunaljubce pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
…che#42629) * Include object router and migrate objects/historical_metrics_data to FastAPI * Use pyfixture session * Include provide_session for SQLite session thread issue * Make method async and remove unused session from tests * Include return type to generate proper openapi spec * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Include pydantic model for Dashboard Historical Metric Data and convert response to HistoricalMetricDataResponse * Fix conflict and rerun pre-commit hooks * Rename data variable to historical metrics for consistency * Include object router and migrate objects/historical_metrics_data to FastAPI * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Drop data from method name to prevent double Data in the name of objects * Variable name change to prevent shadow naming with method name * Resolve conflicts and rebase again * Resolve conflicts and rebase
pavansharma36 pushed a commit
to pavansharma36/airflow
that referenced
this pull request
Oct 14, 2024
…che#42629) * Include object router and migrate objects/historical_metrics_data to FastAPI * Use pyfixture session * Include provide_session for SQLite session thread issue * Make method async and remove unused session from tests * Include return type to generate proper openapi spec * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Include pydantic model for Dashboard Historical Metric Data and convert response to HistoricalMetricDataResponse * Fix conflict and rerun pre-commit hooks * Rename data variable to historical metrics for consistency * Include object router and migrate objects/historical_metrics_data to FastAPI * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Drop data from method name to prevent double Data in the name of objects * Variable name change to prevent shadow naming with method name * Resolve conflicts and rebase again * Resolve conflicts and rebase
R7L208 pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
…che#42629) * Include object router and migrate objects/historical_metrics_data to FastAPI * Use pyfixture session * Include provide_session for SQLite session thread issue * Make method async and remove unused session from tests * Include return type to generate proper openapi spec * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Include pydantic model for Dashboard Historical Metric Data and convert response to HistoricalMetricDataResponse * Fix conflict and rerun pre-commit hooks * Rename data variable to historical metrics for consistency * Include object router and migrate objects/historical_metrics_data to FastAPI * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Drop data from method name to prevent double Data in the name of objects * Variable name change to prevent shadow naming with method name * Resolve conflicts and rebase again * Resolve conflicts and rebase
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
…che#42629) * Include object router and migrate objects/historical_metrics_data to FastAPI * Use pyfixture session * Include provide_session for SQLite session thread issue * Make method async and remove unused session from tests * Include return type to generate proper openapi spec * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Include pydantic model for Dashboard Historical Metric Data and convert response to HistoricalMetricDataResponse * Fix conflict and rerun pre-commit hooks * Rename data variable to historical metrics for consistency * Include object router and migrate objects/historical_metrics_data to FastAPI * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Drop data from method name to prevent double Data in the name of objects * Variable name change to prevent shadow naming with method name * Resolve conflicts and rebase again * Resolve conflicts and rebase
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…che#42629) * Include object router and migrate objects/historical_metrics_data to FastAPI * Use pyfixture session * Include provide_session for SQLite session thread issue * Make method async and remove unused session from tests * Include return type to generate proper openapi spec * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Include pydantic model for Dashboard Historical Metric Data and convert response to HistoricalMetricDataResponse * Fix conflict and rerun pre-commit hooks * Rename data variable to historical metrics for consistency * Include object router and migrate objects/historical_metrics_data to FastAPI * Object definition to Dashboard definition, make safe date Annotated parameter in parameters.py * Drop data from method name to prevent double Data in the name of objects * Variable name change to prevent shadow naming with method name * Resolve conflicts and rebase again * Resolve conflicts and rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #42623
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.